You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrii Babiichuk <ab...@hortonworks.com> on 2017/08/22 17:45:40 UTC

Review Request 61819: Log Search UI: implement timezone picker

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61819/
-----------------------------------------------------------

Review request for Ambari and Andrii Tkach.


Bugs: AMBARI-21783
    https://issues.apache.org/jira/browse/AMBARI-21783


Repository: ambari


Description
-------

Implement timezone picker in form of interactive world map instead of dropdown select list.


Diffs
-----

  ambari-logsearch/ambari-logsearch-web-new/src/app/app.module.ts 775ac55 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.html a353f4d 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.ts 1622f7c 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.html 4f751fd 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.less 6b18e91 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.ts b145a94 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/login-form/login-form.component.ts 62c71f1 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.ts c77fa5c 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/main-container/main-container.component.ts 78df822 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/modal/modal.component.html PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/modal/modal.component.spec.ts PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/modal/modal.component.ts PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/time-histogram/time-histogram.component.ts 1dfd1f8 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/timezone-picker/timezone-picker.component.html PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/timezone-picker/timezone-picker.component.less PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/timezone-picker/timezone-picker.component.spec.ts PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/timezone-picker/timezone-picker.component.ts PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web-new/src/app/components/variables.less 0d739a1 
  ambari-logsearch/ambari-logsearch-web-new/src/app/mock-data.ts 1f738ae 
  ambari-logsearch/ambari-logsearch-web-new/src/app/pipes/timezone-abbr.pipe.spec.ts PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web-new/src/app/pipes/timezone-abbr.pipe.ts PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts 9a589cc 
  ambari-logsearch/ambari-logsearch-web-new/src/app/services/utils.service.ts 2deff9e 
  ambari-logsearch/ambari-logsearch-web-new/src/assets/i18n/en.json 1b71f24 
  ambari-logsearch/ambari-logsearch-web-new/src/vendor/js/WorldMapGenerator.min.js PRE-CREATION 
  ambari-logsearch/ambari-logsearch-web-new/tsconfig.json fc7c1f7 


Diff: https://reviews.apache.org/r/61819/diff/1/


Testing
-------

Executed 81 of 81 SUCCESS (1.512 secs / 1.477 secs)


Thanks,

Andrii Babiichuk


Re: Review Request 61819: Log Search UI: implement timezone picker

Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61819/#review183499
-----------------------------------------------------------


Ship it!




Ship It!

- Andrii Tkach


On Aug. 22, 2017, 5:45 p.m., Andrii Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61819/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2017, 5:45 p.m.)
> 
> 
> Review request for Ambari and Andrii Tkach.
> 
> 
> Bugs: AMBARI-21783
>     https://issues.apache.org/jira/browse/AMBARI-21783
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Implement timezone picker in form of interactive world map instead of dropdown select list.
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/app.module.ts 775ac55 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.html a353f4d 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/app.component.ts 1622f7c 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.html 4f751fd 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.less 6b18e91 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/filters-panel/filters-panel.component.ts b145a94 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/login-form/login-form.component.ts 62c71f1 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/logs-container/logs-container.component.ts c77fa5c 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/main-container/main-container.component.ts 78df822 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/modal/modal.component.html PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/modal/modal.component.spec.ts PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/modal/modal.component.ts PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/time-histogram/time-histogram.component.ts 1dfd1f8 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/timezone-picker/timezone-picker.component.html PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/timezone-picker/timezone-picker.component.less PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/timezone-picker/timezone-picker.component.spec.ts PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/timezone-picker/timezone-picker.component.ts PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/components/variables.less 0d739a1 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/mock-data.ts 1f738ae 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/pipes/timezone-abbr.pipe.spec.ts PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/pipes/timezone-abbr.pipe.ts PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/services/filtering.service.ts 9a589cc 
>   ambari-logsearch/ambari-logsearch-web-new/src/app/services/utils.service.ts 2deff9e 
>   ambari-logsearch/ambari-logsearch-web-new/src/assets/i18n/en.json 1b71f24 
>   ambari-logsearch/ambari-logsearch-web-new/src/vendor/js/WorldMapGenerator.min.js PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-web-new/tsconfig.json fc7c1f7 
> 
> 
> Diff: https://reviews.apache.org/r/61819/diff/1/
> 
> 
> Testing
> -------
> 
> Executed 81 of 81 SUCCESS (1.512 secs / 1.477 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>