You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "toddmeng-db (via GitHub)" <gi...@apache.org> on 2025/08/22 00:38:20 UTC

[PR] [PECO-2396] Set timestamp configuration on open-session request [arrow-adbc]

toddmeng-db opened a new pull request, #3327:
URL: https://github.com/apache/arrow-adbc/pull/3327

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [PECO-2396] Set timestamp configuration on open-session request [arrow-adbc]

Posted by "toddmeng-db (via GitHub)" <gi...@apache.org>.
toddmeng-db commented on code in PR #3327:
URL: https://github.com/apache/arrow-adbc/pull/3327#discussion_r2292423859


##########
csharp/src/Drivers/Apache/Spark/SparkConnection.cs:
##########
@@ -35,11 +35,6 @@ internal abstract class SparkConnection : HiveServer2Connection
 
         internal static TSparkGetDirectResults sparkGetDirectResults = new TSparkGetDirectResults(1000);
 

Review Comment:
   Confirmed this is a databricks-runtime config value



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(csharp/src/Drivers/Databricks): [PECO-2396] Fix timestamp for dbr 6.6 - Set timestamp configuration on OpenSessionReq [arrow-adbc]

Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher merged PR #3327:
URL: https://github.com/apache/arrow-adbc/pull/3327


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(csharp/src/Drivers/Databricks): [PECO-2396] Fix timestamp for dbr 6.6 - Set timestamp configuration on OpenSessionReq [arrow-adbc]

Posted by "toddmeng-db (via GitHub)" <gi...@apache.org>.
toddmeng-db commented on code in PR #3327:
URL: https://github.com/apache/arrow-adbc/pull/3327#discussion_r2292437125


##########
csharp/src/Drivers/Databricks/DatabricksConnection.cs:
##########
@@ -592,6 +597,11 @@ protected override TOpenSessionReq CreateSessionRequest()
                 {
                     req.Configuration[property.Key] = property.Value;
                 }

Review Comment:
   actually, let me put this before, in case user wants to override it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [PECO-2396] Set timestamp configuration on open-session request [arrow-adbc]

Posted by "toddmeng-db (via GitHub)" <gi...@apache.org>.
toddmeng-db commented on code in PR #3327:
URL: https://github.com/apache/arrow-adbc/pull/3327#discussion_r2292423859


##########
csharp/src/Drivers/Apache/Spark/SparkConnection.cs:
##########
@@ -35,11 +35,6 @@ internal abstract class SparkConnection : HiveServer2Connection
 
         internal static TSparkGetDirectResults sparkGetDirectResults = new TSparkGetDirectResults(1000);
 

Review Comment:
   This is a databricks-runtime config value



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(csharp/src/Drivers/Databricks): [PECO-2396] Fix timestamp for dbr 6.6 - Set timestamp configuration on OpenSessionReq [arrow-adbc]

Posted by "birschick-bq (via GitHub)" <gi...@apache.org>.
birschick-bq commented on code in PR #3327:
URL: https://github.com/apache/arrow-adbc/pull/3327#discussion_r2298998439


##########
csharp/src/Drivers/Databricks/DatabricksConnection.cs:
##########
@@ -47,6 +47,11 @@ internal class DatabricksConnection : SparkHttpConnection
         /// </summary>
         public const string DefaultConfigEnvironmentVariable = "DATABRICKS_CONFIG_FILE";
 
+        internal static readonly Dictionary<string, string> timestampConfig = new Dictionary<string, string>
+        {
+            { "spark.thriftserver.arrowBasedRowSet.timestampAsString", "false" },
+        };
+        

Review Comment:
   nit: trailing whitespace
   ```suggestion
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org