You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/08 11:07:31 UTC

[GitHub] [tvm] leandron commented on pull request #7577: [TVMC][VitisAI] Enable Vitis AI target through TVMC

leandron commented on pull request #7577:
URL: https://github.com/apache/tvm/pull/7577#issuecomment-792679681


   > @leandron Do you have any thoughts on documenting TVMC target usage?
   > 
   > > **Documentation**
   > > I think we should document the use of these targets but not sure what the best place is. For example, we can add documentation to https://tvm.apache.org/docs/tutorials/get_started/tvmc_command_line_driver.html or in the target deploy and integration documentation (for example here: https://tvm.apache.org/docs/deploy/vitis_ai.html). Or we can do both?
   I agree this is 
   
   Yes, I agree this is something we need to improve. Actually in general for targets in TVM it is not easy to obtain meta-information without inspecting the code.
   
   Ideally, I'd like to make the targets self-documenting, so that we don't need to update a page and keep it in sync with changes we do in the code, and users can find useful help on the `--help` option - it is fine if you have your own documentation page, to write about the options, but I'm not sure this should be our _official_ documentation. So that would be my recommendation for now.
   
   I was planning to submit a separate PR, making `--help` list the available TVM targets plus our composite targets here. This one is very easy (yet not 100% complete as a feature), but I think should be done in a separate PR.
   
   For the inner options, such as `-mcpu` for `llvm`, and `-dpu` for `vitis-ai`, I think it would require a bit of refactoring, to make that an exposed API in TVM level, just consuming that on TVMC.
   
   Concretely, I don't think this should block your PR here. But certainly is a very important topic to start a broader discussion. (cc @masahi @comaniac @junrushao1994)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org