[GitHub] rafaelweingartner commented on a change in pull request #2829: CLOUDSTACK-9473: storage pool capacity check when volume is resized or migrated

[GitBox <gi...@apache.org>]

rafaelweingartner commented on a change in pull request #2829: CLOUDSTACK-9473: storage pool capacity check when volume is resized or migrated
URL: https://github.com/apache/cloudstack/pull/2829#discussion_r214514105
 
 

 ##########
 File path: server/src/com/cloud/storage/StorageManagerImpl.java
 ##########
 @@ -1847,21 +1872,26 @@ public boolean storagePoolHasEnoughSpace(List<Volume> volumes, StoragePool pool,
         s_logger.debug("Total capacity of the pool " + poolVO.getName() + " with ID " + pool.getId() + " is " + totalOverProvCapacity);
 
         double storageAllocatedThreshold = CapacityManager.StorageAllocatedCapacityDisableThreshold.valueIn(pool.getDataCenterId());
-
-        s_logger.debug("Checking pool: " + pool.getId() + " for volume allocation " + volumes.toString() + ", maxSize : " + totalOverProvCapacity + ", totalAllocatedSize : "
-                + allocatedSizeWithTemplate + ", askingSize : " + totalAskingSize + ", allocated disable threshold: " + storageAllocatedThreshold);
+        if (s_logger.isDebugEnabled()) {
 
 Review comment:
   I still see no real benefits of adding this log level checks in our context. On the other hand, I do see problems with readability of the code. 
   
   I cannot object though, if you want to proceed with this ;) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services