[GitHub] [airflow] iroddis commented on a change in pull request #5787: [AIRFLOW-5172] Add choice of interval edge scheduling

[GitBox <gi...@apache.org>]

iroddis commented on a change in pull request #5787: [AIRFLOW-5172] Add choice of interval edge scheduling
URL: https://github.com/apache/airflow/pull/5787#discussion_r315165919
 
 

 ##########
 File path: airflow/config_templates/default_airflow.cfg
 ##########
 @@ -511,6 +511,10 @@ scheduler_zombie_task_threshold = 300
 # DAG definition (catchup)
 catchup_by_default = True
 
+# Should DAGs be schedule to execute at the 'start' or 'end'
+# of their schedule interval.
+execute_at_interval_end = True
 
 Review comment:
   I'm all for hair splitting if it means clearer usage down the road, and is more consistent with established nomenclature.
   
   Part of my confusion is that `schedule` seams to have multiple meanings: A job scheduled daily will be scheduled to run once the day has finished. So there's the declared schedule, and then the implied schedule (execution time).
   
   I have no vested interest in the name, just let me know if you'd like to change it.
   
   Either way, maybe it would be worth adding (in a separate PR) a dictionary of terms and precise definitions? I'd be happy submit that after this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services