You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/03/20 01:57:00 UTC
[jira] [Work logged] (BEAM-6770) Correct zstd-jni dependency scope
to optional
[ https://issues.apache.org/jira/browse/BEAM-6770?focusedWorklogId=215947&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-215947 ]
ASF GitHub Bot logged work on BEAM-6770:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/19 01:56
Start Date: 20/Mar/19 01:56
Worklog Time Spent: 10m
Work Description: jklukas commented on pull request #8096: [BEAM-6770] Correct zstd-jni dependency scope to tests only
URL: https://github.com/apache/beam/pull/8096
As discussed in [the Jira ticket](https://issues.apache.org/jira/browse/BEAM-6770),
we are moving this dependency to be test-only by default and documenting
that it's the user's responsibility to explicitly declare a dependency on
`zstd-jni` before attempting to read or write .zst files.
`zstd-jni` is effectively now an optional dependency, even though it won't
be explicity listed as such in the produced pom. The cost:benefit ratio
of codifying an optional dependency in the build is considered low
at this point.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python3_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) <br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/) | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 215947)
Time Spent: 10m
Remaining Estimate: 0h
> Correct zstd-jni dependency scope to optional
> ---------------------------------------------
>
> Key: BEAM-6770
> URL: https://issues.apache.org/jira/browse/BEAM-6770
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Romain Manni-Bucau
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Beam 2.11.0 introduced a new transitive dep aka zstd-jni. AFAIK it is not needed in most cases so shouldn't be here by default. Also saw it was configured as shadow in the sdk core java module so not sure it is a gradle build bug or intended to be like that but I think sdk-core-java should be cleaned up cause it is now very fast and does not match a lot of usage. Finally this lib being native it is not that sane to bring it by default, in particular with the dockerization happening right now and the goal to have a light container stack (which often implies to not use standard linux as FROM).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)