You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2019/12/11 07:54:18 UTC

[GitHub] [incubator-echarts] yafengstark opened a new pull request #11833: Fix 11799

yafengstark opened a new pull request #11833: Fix 11799
URL: https://github.com/apache/incubator-echarts/pull/11833
 
 
   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [x] new feature
   
   
   
   
   
   ### What does this PR do?
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   
   Add a Feature about series "map" :
   Customrize geojson properties name tag, default is "name". Now, you can use "NAME", "nName" and so on.
   
   ### Fixed issues
   
   bug [11799](https://github.com/apache/incubator-echarts/issues/11799)
   
   
   ## Details
   
   ### Before: What was the problem?
   
   <!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
   In original version, geojson properties must have a tag: "name". Now you can customrize it.
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   
   ### After: How is it fixed in this PR?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   discussion and read the code.
   
   ## Usage
   
   It is used widely. Geojson standard doesn't clear and definite the tag "name".
   
   ### Are there any API changes?
   
   - [x] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   ```
   {
                               name: 'USA PopEstimates',
                               type: 'map',
                               roam: true,
                               map: 'USA',
                               nameTag: 'NAME', // this is new option, default is 'name'
                               itemStyle: {
                                   emphasis: {label: {show: true}}
                               }
   }
   ```
   
   ### Related test cases or examples to use the new APIs
   
   https://github.com/yafengstark/incubator-echarts/blob/fix-11799/test/visualMap-fix-11799.html
   
   Sorry, the test case is named as "map-fix-11799.html".
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org