[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #817: MINIFICPP-1262 Fix the MinifiConcurrentQueueTests unit tests

[GitBox <gi...@apache.org>]

arpadboda commented on a change in pull request #817:
URL: https://github.com/apache/nifi-minifi-cpp/pull/817#discussion_r441331905



##########
File path: libminifi/test/unit/MinifiConcurrentQueueTests.cpp
##########
@@ -31,6 +31,20 @@ namespace utils = org::apache::nifi::minifi::utils;
 
 namespace {
 
+  template <typename Function, typename Duration>

Review comment:
       I think relying on chrono::duration is a bit more bulletproof:
   ```
   template<typename Function, class Rep, class Period>
   bool becomesTrueWithinTimeout(const Function &conditio, const std::chrono::duration<Rep, Period>& timeout) {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org