You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/22 08:47:29 UTC

[GitHub] [shardingsphere] guojia1698 opened a new pull request #8289: Update the sub class ShardingCTLShowBackendHandler of TextProtocolBackendHandler 

guojia1698 opened a new pull request #8289:
URL: https://github.com/apache/shardingsphere/pull/8289


   Fixes #8243 .
   
   Changes proposed in this pull request:
   Update the sub class ShardingCTLShowBackendHandler of TextProtocolBackendHandler 
   -
   -
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] kimmking commented on a change in pull request #8289: Update the sub class ShardingCTLShowBackendHandler of TextProtocolBackendHandler

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #8289:
URL: https://github.com/apache/shardingsphere/pull/8289#discussion_r528327054



##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/sctl/hint/ShardingCTLHintBackendHandler.java
##########
@@ -43,7 +43,10 @@
     private final BackendConnection backendConnection;
     
     private HintCommandExecutor hintCommandExecutor;
-    
+
+    public ShardingCTLHintBackendHandler() {

Review comment:
       why add a constructor?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io edited a comment on pull request #8289: Update the sub class ShardingCTLShowBackendHandler of TextProtocolBackendHandler

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #8289:
URL: https://github.com/apache/shardingsphere/pull/8289#issuecomment-732479896


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=h1) Report
   > Merging [#8289](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=desc) (d910e09) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a07d5c4e96f4ee1eea91a6a58b4adf3541ac0750?el=desc) (a07d5c4) will **decrease** coverage by `1.27%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8289/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8289      +/-   ##
   ============================================
   - Coverage     74.72%   73.45%   -1.28%     
   - Complexity      600      606       +6     
   ============================================
     Files          1483     1500      +17     
     Lines         23435    23871     +436     
     Branches       4174     4222      +48     
   ============================================
   + Hits          17512    17534      +22     
   - Misses         4772     5169     +397     
   - Partials       1151     1168      +17     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../text/sctl/hint/ShardingCTLHintBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L3NjdGwvaGludC9TaGFyZGluZ0NUTEhpbnRCYWNrZW5kSGFuZGxlci5qYXZh) | `80.00% <ø> (+7.27%)` | `0.00 <0.00> (ø)` | |
   | [...a/spring/namespace/handler/HANamespaceHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWhhLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2hhL3NwcmluZy9uYW1lc3BhY2UvaGFuZGxlci9IQU5hbWVzcGFjZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...g/namespace/parser/HARuleBeanDefinitionParser.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWhhLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2hhL3NwcmluZy9uYW1lc3BhY2UvcGFyc2VyL0hBUnVsZUJlYW5EZWZpbml0aW9uUGFyc2VyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...rybean/ReplicaLoadBalanceAlgorithmFactoryBean.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWhhLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2hhL3NwcmluZy9uYW1lc3BhY2UvZmFjdG9yeWJlYW4vUmVwbGljYUxvYWRCYWxhbmNlQWxnb3JpdGhtRmFjdG9yeUJlYW4uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...java/org/apache/shardingsphere/ha/rule/HARule.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9oYS9ydWxlL0hBUnVsZS5qYXZh) | `54.54% <0.00%> (-31.57%)` | `0.00% <0.00%> (ø%)` | |
   | [...ere/scaling/core/datasource/DataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9kYXRhc291cmNlL0RhdGFTb3VyY2VGYWN0b3J5LmphdmE=) | `66.66% <0.00%> (-14.59%)` | `1.00% <0.00%> (ø%)` | |
   | [...ardingsphere/infra/spi/typed/TypedSPIRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9zcGkvdHlwZWQvVHlwZWRTUElSZWdpc3RyeS5qYXZh) | `86.66% <0.00%> (-13.34%)` | `0.00% <0.00%> (ø%)` | |
   | [.../executor/sql/context/ExecutionContextBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9jb250ZXh0L0V4ZWN1dGlvbkNvbnRleHRCdWlsZGVyLmphdmE=) | `77.77% <0.00%> (-7.08%)` | `0.00% <0.00%> (ø%)` | |
   | [...r/jdbc/core/statement/ShardingSphereStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nU3BoZXJlU3RhdGVtZW50LmphdmE=) | `59.28% <0.00%> (-6.94%)` | `1.00% <0.00%> (ø%)` | |
   | [...ere/governance/repository/etcd/EtcdRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLXJlcG9zaXRvcnkvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1yZXBvc2l0b3J5LXByb3ZpZGVyL3NoYXJkaW5nc3BoZXJlLWdvdmVybmFuY2UtcmVwb3NpdG9yeS1ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9nb3Zlcm5hbmNlL3JlcG9zaXRvcnkvZXRjZC9FdGNkUmVwb3NpdG9yeS5qYXZh) | `84.78% <0.00%> (-5.92%)` | `15.00% <0.00%> (ø%)` | |
   | ... and [203 more](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=footer). Last update [a07d5c4...d910e09](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #8289: Update the sub class ShardingCTLShowBackendHandler of TextProtocolBackendHandler

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #8289:
URL: https://github.com/apache/shardingsphere/pull/8289


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #8289: Update the sub class ShardingCTLShowBackendHandler of TextProtocolBackendHandler

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8289:
URL: https://github.com/apache/shardingsphere/pull/8289#issuecomment-732479896


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=h1) Report
   > Merging [#8289](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=desc) (1ef0314) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a07d5c4e96f4ee1eea91a6a58b4adf3541ac0750?el=desc) (a07d5c4) will **decrease** coverage by `0.68%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8289/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8289      +/-   ##
   ============================================
   - Coverage     74.72%   74.04%   -0.69%     
   + Complexity      600      599       -1     
   ============================================
     Files          1483     1494      +11     
     Lines         23435    23641     +206     
     Branches       4174     4179       +5     
   ============================================
   - Hits          17512    17505       -7     
   - Misses         4772     4987     +215     
   + Partials       1151     1149       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../text/sctl/hint/ShardingCTLHintBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L3NjdGwvaGludC9TaGFyZGluZ0NUTEhpbnRCYWNrZW5kSGFuZGxlci5qYXZh) | `80.00% <ø> (+7.27%)` | `0.00 <0.00> (ø)` | |
   | [...ere/scaling/core/datasource/DataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9kYXRhc291cmNlL0RhdGFTb3VyY2VGYWN0b3J5LmphdmE=) | `66.66% <0.00%> (-14.59%)` | `1.00% <0.00%> (ø%)` | |
   | [...ere/scaling/core/utils/ProxyConfigurationUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS91dGlscy9Qcm94eUNvbmZpZ3VyYXRpb25VdGlsLmphdmE=) | `95.45% <0.00%> (-1.22%)` | `0.00% <0.00%> (ø%)` | |
   | [.../core/job/preparer/ShardingScalingJobPreparer.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcHJlcGFyZXIvU2hhcmRpbmdTY2FsaW5nSm9iUHJlcGFyZXIuamF2YQ==) | `92.85% <0.00%> (-0.48%)` | `0.00% <0.00%> (ø%)` | |
   | [...on/jdbc/execute/engine/jdbc/JDBCExecuteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvZXhlY3V0ZS9lbmdpbmUvamRiYy9KREJDRXhlY3V0ZUVuZ2luZS5qYXZh) | `13.04% <0.00%> (-0.29%)` | `0.00% <0.00%> (ø%)` | |
   | [...here/scaling/core/utils/SyncConfigurationUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS91dGlscy9TeW5jQ29uZmlndXJhdGlvblV0aWwuamF2YQ==) | `88.41% <0.00%> (-0.08%)` | `52.00% <0.00%> (ø%)` | |
   | [...rdingsphere/driver/executor/StatementExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9leGVjdXRvci9TdGF0ZW1lbnRFeGVjdXRvci5qYXZh) | `96.55% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
   | [...apache/shardingsphere/scaling/ServerBootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWJvb3RzdHJhcC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9TZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...apache/shardingsphere/scaling/WorkerBootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWJvb3RzdHJhcC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9Xb3JrZXJCb290c3RyYXAuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...ere/driver/executor/PreparedStatementExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9leGVjdXRvci9QcmVwYXJlZFN0YXRlbWVudEV4ZWN1dG9yLmphdmE=) | `95.65% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
   | ... and [64 more](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=footer). Last update [a07d5c4...1ef0314](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io edited a comment on pull request #8289: Update the sub class ShardingCTLShowBackendHandler of TextProtocolBackendHandler

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #8289:
URL: https://github.com/apache/shardingsphere/pull/8289#issuecomment-732479896


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=h1) Report
   > Merging [#8289](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=desc) (1ef0314) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a07d5c4e96f4ee1eea91a6a58b4adf3541ac0750?el=desc) (a07d5c4) will **decrease** coverage by `0.68%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8289/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8289      +/-   ##
   ============================================
   - Coverage     74.72%   74.04%   -0.69%     
   + Complexity      600      599       -1     
   ============================================
     Files          1483     1494      +11     
     Lines         23435    23641     +206     
     Branches       4174     4179       +5     
   ============================================
   - Hits          17512    17505       -7     
   - Misses         4772     4987     +215     
   + Partials       1151     1149       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../text/sctl/hint/ShardingCTLHintBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L3NjdGwvaGludC9TaGFyZGluZ0NUTEhpbnRCYWNrZW5kSGFuZGxlci5qYXZh) | `80.00% <ø> (+7.27%)` | `0.00 <0.00> (ø)` | |
   | [...ere/scaling/core/datasource/DataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9kYXRhc291cmNlL0RhdGFTb3VyY2VGYWN0b3J5LmphdmE=) | `66.66% <0.00%> (-14.59%)` | `1.00% <0.00%> (ø%)` | |
   | [...ere/scaling/core/utils/ProxyConfigurationUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS91dGlscy9Qcm94eUNvbmZpZ3VyYXRpb25VdGlsLmphdmE=) | `95.45% <0.00%> (-1.22%)` | `0.00% <0.00%> (ø%)` | |
   | [.../core/job/preparer/ShardingScalingJobPreparer.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcHJlcGFyZXIvU2hhcmRpbmdTY2FsaW5nSm9iUHJlcGFyZXIuamF2YQ==) | `92.85% <0.00%> (-0.48%)` | `0.00% <0.00%> (ø%)` | |
   | [...on/jdbc/execute/engine/jdbc/JDBCExecuteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvZXhlY3V0ZS9lbmdpbmUvamRiYy9KREJDRXhlY3V0ZUVuZ2luZS5qYXZh) | `13.04% <0.00%> (-0.29%)` | `0.00% <0.00%> (ø%)` | |
   | [...here/scaling/core/utils/SyncConfigurationUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS91dGlscy9TeW5jQ29uZmlndXJhdGlvblV0aWwuamF2YQ==) | `88.41% <0.00%> (-0.08%)` | `52.00% <0.00%> (ø%)` | |
   | [...rdingsphere/driver/executor/StatementExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9leGVjdXRvci9TdGF0ZW1lbnRFeGVjdXRvci5qYXZh) | `96.55% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
   | [...apache/shardingsphere/scaling/ServerBootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWJvb3RzdHJhcC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9TZXJ2ZXJCb290c3RyYXAuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...apache/shardingsphere/scaling/WorkerBootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWJvb3RzdHJhcC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2NhbGluZy9Xb3JrZXJCb290c3RyYXAuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...ere/driver/executor/PreparedStatementExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9leGVjdXRvci9QcmVwYXJlZFN0YXRlbWVudEV4ZWN1dG9yLmphdmE=) | `95.65% <0.00%> (ø)` | `1.00% <0.00%> (ø%)` | |
   | ... and [64 more](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=footer). Last update [a07d5c4...1ef0314](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on a change in pull request #8289: Update the sub class ShardingCTLShowBackendHandler of TextProtocolBackendHandler

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #8289:
URL: https://github.com/apache/shardingsphere/pull/8289#discussion_r529600455



##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/test/java/org/apache/shardingsphere/proxy/backend/text/sctl/hint/ShardingCTLHintBackendHandlerTest.java
##########
@@ -141,7 +141,7 @@ public void assertShowStatus() throws SQLException {
         assertThat(((QueryResponse) backendResponse).getQueryHeaders().get(0).getColumnLabel(), is("primary_only"));
         assertThat(((QueryResponse) backendResponse).getQueryHeaders().get(1).getColumnLabel(), is("sharding_type"));
         assertTrue(defaultHintBackendHandler.next());
-        List<Object> defaultRowData = defaultHintBackendHandler.getRowData();
+        List<Object> defaultRowData = (List<Object>) defaultHintBackendHandler.getRowData();

Review comment:
       Cloud you use Iterator instead of cast list?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io edited a comment on pull request #8289: Update the sub class ShardingCTLShowBackendHandler of TextProtocolBackendHandler

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #8289:
URL: https://github.com/apache/shardingsphere/pull/8289#issuecomment-732479896


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=h1) Report
   > Merging [#8289](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=desc) (d910e09) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a07d5c4e96f4ee1eea91a6a58b4adf3541ac0750?el=desc) (a07d5c4) will **decrease** coverage by `1.27%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8289/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8289      +/-   ##
   ============================================
   - Coverage     74.72%   73.44%   -1.28%     
   - Complexity      600      606       +6     
   ============================================
     Files          1483     1500      +17     
     Lines         23435    23871     +436     
     Branches       4174     4222      +48     
   ============================================
   + Hits          17512    17533      +21     
   - Misses         4772     5169     +397     
   - Partials       1151     1169      +18     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../text/sctl/hint/ShardingCTLHintBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L3NjdGwvaGludC9TaGFyZGluZ0NUTEhpbnRCYWNrZW5kSGFuZGxlci5qYXZh) | `80.00% <ø> (+7.27%)` | `0.00 <0.00> (ø)` | |
   | [...a/spring/namespace/handler/HANamespaceHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWhhLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2hhL3NwcmluZy9uYW1lc3BhY2UvaGFuZGxlci9IQU5hbWVzcGFjZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...g/namespace/parser/HARuleBeanDefinitionParser.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWhhLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2hhL3NwcmluZy9uYW1lc3BhY2UvcGFyc2VyL0hBUnVsZUJlYW5EZWZpbml0aW9uUGFyc2VyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
   | [...rybean/ReplicaLoadBalanceAlgorithmFactoryBean.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWhhLXNwcmluZy1uYW1lc3BhY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2hhL3NwcmluZy9uYW1lc3BhY2UvZmFjdG9yeWJlYW4vUmVwbGljYUxvYWRCYWxhbmNlQWxnb3JpdGhtRmFjdG9yeUJlYW4uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...java/org/apache/shardingsphere/ha/rule/HARule.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtaGEvc2hhcmRpbmdzcGhlcmUtaGEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9oYS9ydWxlL0hBUnVsZS5qYXZh) | `54.54% <0.00%> (-31.57%)` | `0.00% <0.00%> (ø%)` | |
   | [...ere/scaling/core/datasource/DataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9kYXRhc291cmNlL0RhdGFTb3VyY2VGYWN0b3J5LmphdmE=) | `66.66% <0.00%> (-14.59%)` | `1.00% <0.00%> (ø%)` | |
   | [...ardingsphere/infra/spi/typed/TypedSPIRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9zcGkvdHlwZWQvVHlwZWRTUElSZWdpc3RyeS5qYXZh) | `86.66% <0.00%> (-13.34%)` | `0.00% <0.00%> (ø%)` | |
   | [.../executor/sql/context/ExecutionContextBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtZXhlY3V0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL2V4ZWN1dG9yL3NxbC9jb250ZXh0L0V4ZWN1dGlvbkNvbnRleHRCdWlsZGVyLmphdmE=) | `77.77% <0.00%> (-7.08%)` | `0.00% <0.00%> (ø%)` | |
   | [...r/jdbc/core/statement/ShardingSphereStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nU3BoZXJlU3RhdGVtZW50LmphdmE=) | `59.28% <0.00%> (-6.94%)` | `1.00% <0.00%> (ø%)` | |
   | [...ere/governance/repository/etcd/EtcdRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLXJlcG9zaXRvcnkvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1yZXBvc2l0b3J5LXByb3ZpZGVyL3NoYXJkaW5nc3BoZXJlLWdvdmVybmFuY2UtcmVwb3NpdG9yeS1ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9nb3Zlcm5hbmNlL3JlcG9zaXRvcnkvZXRjZC9FdGNkUmVwb3NpdG9yeS5qYXZh) | `84.78% <0.00%> (-5.92%)` | `15.00% <0.00%> (ø%)` | |
   | ... and [204 more](https://codecov.io/gh/apache/shardingsphere/pull/8289/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=footer). Last update [a07d5c4...d910e09](https://codecov.io/gh/apache/shardingsphere/pull/8289?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] guojia1698 commented on a change in pull request #8289: Update the sub class ShardingCTLShowBackendHandler of TextProtocolBackendHandler

Posted by GitBox <gi...@apache.org>.
guojia1698 commented on a change in pull request #8289:
URL: https://github.com/apache/shardingsphere/pull/8289#discussion_r528438513



##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/sctl/hint/ShardingCTLHintBackendHandler.java
##########
@@ -43,7 +43,10 @@
     private final BackendConnection backendConnection;
     
     private HintCommandExecutor hintCommandExecutor;
-    
+
+    public ShardingCTLHintBackendHandler() {

Review comment:
       Sorry,this was a mistake,Do I have a chance to resubmit it again?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] kimmking commented on a change in pull request #8289: Update the sub class ShardingCTLShowBackendHandler of TextProtocolBackendHandler

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #8289:
URL: https://github.com/apache/shardingsphere/pull/8289#discussion_r530862075



##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/test/java/org/apache/shardingsphere/proxy/backend/text/sctl/hint/ShardingCTLHintBackendHandlerTest.java
##########
@@ -176,10 +178,11 @@ public void assertShowTableStatus() throws SQLException, NoSuchFieldException, I
         assertThat(((QueryResponse) backendResponse).getQueryHeaders().get(1).getColumnLabel(), is("database_sharding_values"));
         assertThat(((QueryResponse) backendResponse).getQueryHeaders().get(2).getColumnLabel(), is("table_sharding_values"));
         assertTrue(defaultHintBackendHandler.next());
-        List<Object> defaultRowData = defaultHintBackendHandler.getRowData();
-        assertThat(defaultRowData.get(0).toString(), is("user"));
-        assertThat(defaultRowData.get(1).toString(), is(""));
-        assertThat(defaultRowData.get(2).toString(), is(""));
+        List<Object> defaultRowData = (List<Object>) defaultHintBackendHandler.getRowData();

Review comment:
       remove redundant variable




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on a change in pull request #8289: Update the sub class ShardingCTLShowBackendHandler of TextProtocolBackendHandler

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #8289:
URL: https://github.com/apache/shardingsphere/pull/8289#discussion_r528598757



##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/sctl/hint/ShardingCTLHintBackendHandler.java
##########
@@ -43,7 +43,10 @@
     private final BackendConnection backendConnection;
     
     private HintCommandExecutor hintCommandExecutor;
-    
+
+    public ShardingCTLHintBackendHandler() {

Review comment:
       Yes, just git push




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] kimmking commented on a change in pull request #8289: Update the sub class ShardingCTLShowBackendHandler of TextProtocolBackendHandler

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #8289:
URL: https://github.com/apache/shardingsphere/pull/8289#discussion_r529201799



##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/sctl/hint/ShardingCTLHintBackendHandler.java
##########
@@ -43,7 +43,7 @@
     private final BackendConnection backendConnection;
     
     private HintCommandExecutor hintCommandExecutor;
-    

Review comment:
       keep four blanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org