You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "AnuRage-git (via GitHub)" <gi...@apache.org> on 2024/03/13 20:43:09 UTC
[PR] feat : Implement config for services/foundationdb [opendal]
AnuRage-git opened a new pull request, #4355:
URL: https://github.com/apache/opendal/pull/4355
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat : Implement config for services/foundationdb [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #4355:
URL: https://github.com/apache/opendal/pull/4355#discussion_r1527678336
##########
core/src/services/foundationdb/backend.rs:
##########
@@ -25,31 +25,54 @@ use foundationdb::api::NetworkAutoStop;
use foundationdb::Database;
use crate::raw::adapters::kv;
-use crate::raw::normalize_root;
+use crate::raw::*;
use crate::Builder;
use crate::Error;
use crate::ErrorKind;
use crate::Scheme;
use crate::*;
+use serde::Deserialize;
+
/// [foundationdb](https://www.foundationdb.org/) service support.
+///Config for FoundationDB.
+#[derive(Default, Deserialize)]
+#[serde(default)]
+#[non_exhaustive]
+pub struct FoundationConfig {
Review Comment:
Please make sure `FoundationConfig` has been exported in `foundationdb.mod`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat : Implement config for services/foundationdb [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #4355:
URL: https://github.com/apache/opendal/pull/4355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat : Implement config for services/foundationdb [opendal]
Posted by "AnuRage-git (via GitHub)" <gi...@apache.org>.
AnuRage-git commented on code in PR #4355:
URL: https://github.com/apache/opendal/pull/4355#discussion_r1528652315
##########
core/src/services/foundationdb/backend.rs:
##########
@@ -25,31 +25,54 @@ use foundationdb::api::NetworkAutoStop;
use foundationdb::Database;
use crate::raw::adapters::kv;
-use crate::raw::normalize_root;
+use crate::raw::*;
use crate::Builder;
use crate::Error;
use crate::ErrorKind;
use crate::Scheme;
use crate::*;
+use serde::Deserialize;
+
/// [foundationdb](https://www.foundationdb.org/) service support.
+///Config for FoundationDB.
+#[derive(Default, Deserialize)]
+#[serde(default)]
+#[non_exhaustive]
+pub struct FoundationConfig {
Review Comment:
@Xuanwo Fixed it. It was some error with github on my device that it wasn't pushing the commit I made to mod.rs. It's done. All tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat : Implement config for services/foundationdb [opendal]
Posted by "AnuRage-git (via GitHub)" <gi...@apache.org>.
AnuRage-git closed pull request #4355: feat : Implement config for services/foundationdb
URL: https://github.com/apache/opendal/pull/4355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat : Implement config for services/foundationdb [opendal]
Posted by "AnuRage-git (via GitHub)" <gi...@apache.org>.
AnuRage-git commented on PR #4355:
URL: https://github.com/apache/opendal/pull/4355#issuecomment-2002358555
@Xuanwo I've been stuck with the one cargo error since 2 days. Could you take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org