You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/11/21 23:40:50 UTC

[kudu-CR] schema: fast-path for Schema::KeyEquals

Hello Alexey Serbin,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/8627

to review the following change.


Change subject: schema: fast-path for Schema::KeyEquals
......................................................................

schema: fast-path for Schema::KeyEquals

If two schemas are the same object, then KeyEquals can be fast-pathed.

This hasn't been a hot path in release builds, but I noticed a lot of wasted
CPU in a debug build evaluating Schema::KeyEquals, and my suspicion is that in
a great number of cases the objects are identical. Even in release builds, may
as well avoid the unnecessary cycles.

Change-Id: Ia5fadfd70ea651b9105837535f21a34c6e0af6ae
---
M src/kudu/common/schema.h
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/8627/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5fadfd70ea651b9105837535f21a34c6e0af6ae
Gerrit-Change-Number: 8627
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>

[kudu-CR] schema: fast-path for Schema::KeyEquals, etc.

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8627 )

Change subject: schema: fast-path for Schema::KeyEquals, etc.
......................................................................

schema: fast-path for Schema::KeyEquals, etc.

If two schemas are the same object, then KeyEquals can be fast-pathed.
The same goes for various ColumnSchema equality checks.

This hasn't been a hot path in release builds, but I noticed a lot of wasted
CPU in a debug build evaluating Schema::KeyEquals, and my suspicion is that in
a great number of cases the objects are identical. Even in release builds, may
as well avoid the unnecessary cycles.

Change-Id: Ia5fadfd70ea651b9105837535f21a34c6e0af6ae
Reviewed-on: http://gerrit.cloudera.org:8080/8627
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/common/schema.h
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5fadfd70ea651b9105837535f21a34c6e0af6ae
Gerrit-Change-Number: 8627
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] schema: fast-path for Schema::KeyEquals, etc.

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8627

to look at the new patch set (#2).

Change subject: schema: fast-path for Schema::KeyEquals, etc.
......................................................................

schema: fast-path for Schema::KeyEquals, etc.

If two schemas are the same object, then KeyEquals can be fast-pathed.
The same goes for various ColumnSchema equality checks.

This hasn't been a hot path in release builds, but I noticed a lot of wasted
CPU in a debug build evaluating Schema::KeyEquals, and my suspicion is that in
a great number of cases the objects are identical. Even in release builds, may
as well avoid the unnecessary cycles.

Change-Id: Ia5fadfd70ea651b9105837535f21a34c6e0af6ae
---
M src/kudu/common/schema.h
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/8627/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia5fadfd70ea651b9105837535f21a34c6e0af6ae
Gerrit-Change-Number: 8627
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR] schema: fast-path for Schema::KeyEquals

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8627 )

Change subject: schema: fast-path for Schema::KeyEquals
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8627/1/src/kudu/common/schema.h
File src/kudu/common/schema.h:

http://gerrit.cloudera.org:8080/#/c/8627/1/src/kudu/common/schema.h@706
PS1, Line 706:     if (this == &other) return true;
> Does it make sense to add the same for ColumnSchema::{Equals,EqualsType,Equ
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5fadfd70ea651b9105837535f21a34c6e0af6ae
Gerrit-Change-Number: 8627
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 22 Nov 2017 00:30:03 +0000
Gerrit-HasComments: Yes

[kudu-CR] schema: fast-path for Schema::KeyEquals

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8627 )

Change subject: schema: fast-path for Schema::KeyEquals
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8627/1/src/kudu/common/schema.h
File src/kudu/common/schema.h:

http://gerrit.cloudera.org:8080/#/c/8627/1/src/kudu/common/schema.h@706
PS1, Line 706:     if (this == &other) return true;
Does it make sense to add the same for ColumnSchema::{Equals,EqualsType,EqualsPhysicalType} while you are at it?



-- 
To view, visit http://gerrit.cloudera.org:8080/8627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5fadfd70ea651b9105837535f21a34c6e0af6ae
Gerrit-Change-Number: 8627
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 22 Nov 2017 00:18:48 +0000
Gerrit-HasComments: Yes

[kudu-CR] schema: fast-path for Schema::KeyEquals, etc.

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8627 )

Change subject: schema: fast-path for Schema::KeyEquals, etc.
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8627
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5fadfd70ea651b9105837535f21a34c6e0af6ae
Gerrit-Change-Number: 8627
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 22 Nov 2017 00:36:32 +0000
Gerrit-HasComments: No