You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2025/02/14 18:04:00 UTC

[jira] [Commented] (IMPALA-13747) unique_database fixture may taint ImpalaTestSuite.client

    [ https://issues.apache.org/jira/browse/IMPALA-13747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927208#comment-17927208 ] 

ASF subversion and git services commented on IMPALA-13747:
----------------------------------------------------------

Commit e4b5f36003dffb73256c5e614f88ceb5b64e1972 in impala's branch refs/heads/branch-4.5.0 from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=e4b5f3600 ]

IMPALA-13747: Use fresh HS2 client for unique_database fixture

Just like IMPALA-13634 bug, unique_database fixture may taint
ImpalaTestSuite.client by setting 'sync_ddl=True' option and never
cleaning it up for test method usage.

This patch fixes unique_database fixture by always creating fresh HS2
client during CREATE DATABASE and DROP DATABASE.

Testing:
- Caught an assert error at test_set_fallback_db_for_functions
  Expected: "default.fn() unknown for database default"
  Actual: "functional.fn() unknown for database functional"
  In this case, shared ImpalaTestSuite.client may have changed database
  via ImpalaTestSuite.run_test_case() or
  ImpalaTestSuite.execute_wrapper() in other test method.
  Removing unused 'vector' argument somehow fixed the issue.
- For both query_test/test_udfs.py and metadata/test_ddl.py:
  - Fixed flake8 issues and remove unused pytest fixture.
  - Run and pass the tests in exhaustive exploration.

Change-Id: Ib503e829552d436035c57b489ffda0d0299f8405
Reviewed-on: http://gerrit.cloudera.org:8080/22471
Reviewed-by: Riza Suminto <ri...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> unique_database fixture may taint ImpalaTestSuite.client
> --------------------------------------------------------
>
>                 Key: IMPALA-13747
>                 URL: https://issues.apache.org/jira/browse/IMPALA-13747
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Riza Suminto
>            Assignee: Riza Suminto
>            Priority: Major
>
> Just like IMPALA-13634 bug, unique_database fixture may taint ImpalaTestSuite.client by setting 'sync_ddl=True' option, but never cleaning it up for test method usage.
> [https://github.com/apache/impala/blob/856741b1e8371b983da10f23a166f19aac71f1f8/tests/conftest.py#L410-L412] 
> unique_database fixture should use a fresh Impala client for both creating and dropping database.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org