You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by laysakura <gi...@git.apache.org> on 2017/04/14 14:18:07 UTC
[GitHub] thrift pull request #1252: [Ruby] makes exception message more verbose on Ap...
GitHub user laysakura opened a pull request:
https://github.com/apache/thrift/pull/1252
[Ruby] makes exception message more verbose on ApplicationException::INTERNAL_ERROR
## Problem
`ApplicationException::INTERNAL_ERROR` often raised, mainly because of incompatibility between Thrift interface and payload (mistakenly using incorrect Thrift types, breaking changes on Thrift interfaces, ...).
But `ApplicationException::INTERNAL_ERROR` does not provide enough information on what's wrong.
## Solution
Dumps `e.message` and `e.backtrace` .
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/laysakura/thrift rb-verbose-error-message-on-INTERNAL_ERROR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1252.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1252
----
commit 6c79c90cceea8677a59c37873ab94ef568e75b3b
Author: Sho Nakatani <la...@gmail.com>
Date: 2017-04-14T14:08:37Z
[Ruby] makes exception message more verbose on ApplicationException::INTERNAL_ERROR
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1252: [Ruby] Logging server-side exception message on Applicat...
Posted by laysakura <gi...@git.apache.org>.
Github user laysakura commented on the issue:
https://github.com/apache/thrift/pull/1252
@jeking3 Thank you for feedback.
> It would be acceptable to have the server put this information into the GlobalLogger (if Ruby has the same logging concept as the C++ runtime) so that it ends up in a server log file. That would not be a security issue.
I got it.
Ruby code does not have GlobalLogger-like feature, so I use the same code as https://github.com/apache/thrift/blob/master/lib/rb/lib/thrift/server/nonblocking_server.rb#L29-L34 to get a logger.
Please check it \U0001f64f
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1252: [Ruby] Logging server-side exception message on Applicat...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1252
This looks okay to me, but I don't have any ruby experience; hopefully someone else who does can review it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1252: [Ruby] Logging server-side exception message on Applicat...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1252
Great - well once I can commit again, I will. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1252: [Ruby] Logging server-side exception message on A...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1252
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1252: [Ruby] Logging server-side exception message on Applicat...
Posted by allengeorge <gi...@git.apache.org>.
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1252
@jeking3 If you're willing to take this...I have some ruby experience, and this looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1252: [Ruby] Logging server-side exception message on Applicat...
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1252
Tracked in THRIFT-4198. See [our contrib guide](http://thrift.apache.org/docs/HowToContribute) for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1252: [Ruby] makes exception message more verbose on Applicati...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1252
It would be acceptable to have the server put this information into the GlobalLogger (if Ruby has the same logging concept as the C++ runtime) so that it ends up in a server log file. That would not be a security issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---