You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/14 04:19:53 UTC
[GitHub] [airflow] tirkarthi opened a new pull request, #23001: Fix tests using has_calls to use assert_has_calls.
tirkarthi opened a new pull request, #23001:
URL: https://github.com/apache/airflow/pull/23001
Changes made
tests/providers/google/cloud/transfers/test_calendar_to_gcs.py
* Use snake case instead of camel case and mock correct method `get_events` method instead of `get_values`.
tests/providers/google/cloud/hooks/test_cloud_memorystore.py
* Use request instead of name argument as per other tests.
* Use TEST_NAME_DEFAULT_PROJECT_ID when project_id is not passed explicitly and default project_id is set,
closes: #20453
related: #20453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] tirkarthi commented on pull request #23001: Fix tests using has_calls to use assert_has_calls.
Posted by GitBox <gi...@apache.org>.
tirkarthi commented on PR #23001:
URL: https://github.com/apache/airflow/pull/23001#issuecomment-1098694717
@harishkrao Please review the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] harishkrao commented on pull request #23001: Fix tests using has_calls to use assert_has_calls.
Posted by GitBox <gi...@apache.org>.
harishkrao commented on PR #23001:
URL: https://github.com/apache/airflow/pull/23001#issuecomment-1100152173
> @tirkarthi have these assert calls passed when pytest is run? I was working on the fixes for these open issues, so curious if you tested them locally and confirmed if the asserts for airtable and cloud_memorystore on google cloud work.
Don't worry about this. I ran pytest on these changes on my local and they work fine. Thanks for making these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23001: Fix tests using has_calls to use assert_has_calls.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23001:
URL: https://github.com/apache/airflow/pull/23001#issuecomment-1098793177
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #23001: Fix tests using has_calls to use assert_has_calls.
Posted by GitBox <gi...@apache.org>.
mik-laj merged PR #23001:
URL: https://github.com/apache/airflow/pull/23001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org