You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/14 17:46:14 UTC
[GitHub] [spark] Fokko opened a new pull request #29109: [SPARK-32311][PYSPARK] Remove duplicate import
Fokko opened a new pull request #29109:
URL: https://github.com/apache/spark/pull/29109
`datetime` is already imported a few lines below :)
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29109: [SPARK-32311][PYSPARK][TESTS] Remove duplicate import
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29109:
URL: https://github.com/apache/spark/pull/29109#discussion_r454594452
##########
File path: python/pyspark/sql/tests/test_pandas_udf_scalar.py
##########
@@ -14,7 +14,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-import datetime
Review comment:
Hi, @Fokko . The PR title is too broad. Is this fixing all `duplicate` imports?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Fokko commented on pull request #29109: [SPARK-32311][PYSPARK][TESTS] Remove duplicate import
Posted by GitBox <gi...@apache.org>.
Fokko commented on pull request #29109:
URL: https://github.com/apache/spark/pull/29109#issuecomment-658377938
Thanks for picking this up so quickly @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29109: [SPARK-32311][PYSPARK][TESTS] Remove duplicate import
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #29109:
URL: https://github.com/apache/spark/pull/29109#discussion_r454600908
##########
File path: python/pyspark/sql/tests/test_pandas_udf_scalar.py
##########
@@ -14,7 +14,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-import datetime
Review comment:
Great! Then, it's a perfect title.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29109: [SPARK-32311][PYSPARK][TESTS] Remove duplicate import
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29109:
URL: https://github.com/apache/spark/pull/29109#issuecomment-658440803
I assume you cought these by a linter? Let's fix them together in batch next time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29109: [SPARK-32311][PYSPARK] Remove duplicate import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29109:
URL: https://github.com/apache/spark/pull/29109#issuecomment-658321561
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29109: [SPARK-32311][PYSPARK] Remove duplicate import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29109:
URL: https://github.com/apache/spark/pull/29109#issuecomment-658322063
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Fokko commented on a change in pull request #29109: [SPARK-32311][PYSPARK][TESTS] Remove duplicate import
Posted by GitBox <gi...@apache.org>.
Fokko commented on a change in pull request #29109:
URL: https://github.com/apache/spark/pull/29109#discussion_r454595646
##########
File path: python/pyspark/sql/tests/test_pandas_udf_scalar.py
##########
@@ -14,7 +14,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-import datetime
Review comment:
Yes, this is fixing all the duplicate imports:
```
fokkodriesprong@Fan spark % mypy python/ | grep -i "already defined (by an import)"
python/pyspark/sql/tests/test_pandas_udf_scalar.py:25: error: Name 'datetime' already defined (by an import)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #29109: [SPARK-32311][PYSPARK][TESTS] Remove duplicate import
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #29109:
URL: https://github.com/apache/spark/pull/29109
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Fokko commented on pull request #29109: [SPARK-32311][PYSPARK] Remove duplicate import
Posted by GitBox <gi...@apache.org>.
Fokko commented on pull request #29109:
URL: https://github.com/apache/spark/pull/29109#issuecomment-658324369
cc @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Fokko commented on pull request #29109: [SPARK-32311][PYSPARK][TESTS] Remove duplicate import
Posted by GitBox <gi...@apache.org>.
Fokko commented on pull request #29109:
URL: https://github.com/apache/spark/pull/29109#issuecomment-658578504
These PR's are a bit small indeed, but there are a few coming up that are much bigger. I would like to split them a bit to make it easier to digest for the reviewers/committers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29109: [SPARK-32311][PYSPARK][TESTS] Remove duplicate import
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29109:
URL: https://github.com/apache/spark/pull/29109#issuecomment-658455094
@HyukjinKwon . I asked the same question https://github.com/apache/spark/pull/29109#discussion_r454594452 .
@Fokko fixed every instances.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #29109: [SPARK-32311][PYSPARK][TESTS] Remove duplicate import
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #29109:
URL: https://github.com/apache/spark/pull/29109#issuecomment-658469195
Oh, I meant this and https://github.com/apache/spark/pull/29108. But okay I can see these PR could be separate in a way. Thanks guys.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29109: [SPARK-32311][PYSPARK] Remove duplicate import
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29109:
URL: https://github.com/apache/spark/pull/29109#issuecomment-658321561
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org