You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Rick Shaw (JIRA)" <ji...@apache.org> on 2011/07/19 23:18:57 UTC
[jira] [Created] (CASSANDRA-2924) Consolidate JDBC driver classes:
Connection and CassandraConnection in advance of feature additions for 1.1
Consolidate JDBC driver classes: Connection and CassandraConnection in advance of feature additions for 1.1
-----------------------------------------------------------------------------------------------------------
Key: CASSANDRA-2924
URL: https://issues.apache.org/jira/browse/CASSANDRA-2924
Project: Cassandra
Issue Type: Improvement
Components: Drivers
Affects Versions: 0.8.1
Reporter: Rick Shaw
Priority: Minor
Fix For: 0.8.2
For the JDBC Driver suite, additional cleanup and consolidation of classes {{Connection}} and {{CassandraConnection}} were in order. Those changes drove a few casual additional changes in related classes {{CResultSet}}, {{CassandraStatement}} and {{CassandraPreparedStatement}} in order to continue to communicate properly. The class {{Utils}} was also enhanced to move more static utility methods into this holder class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2924) Consolidate JDBC driver
classes: Connection and CassandraConnection in advance of feature additions
for 1.1
Posted by "Rick Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068375#comment-13068375 ]
Rick Shaw commented on CASSANDRA-2924:
--------------------------------------
Thanks for the additions.
> Consolidate JDBC driver classes: Connection and CassandraConnection in advance of feature additions for 1.1
> -----------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-2924
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2924
> Project: Cassandra
> Issue Type: Improvement
> Components: Drivers
> Affects Versions: 0.8.1
> Reporter: Rick Shaw
> Assignee: Rick Shaw
> Priority: Minor
> Labels: JDBC
> Fix For: 0.8.2
>
> Attachments: 2924-v2.txt, consolidate-connection-v1.txt
>
>
> For the JDBC Driver suite, additional cleanup and consolidation of classes {{Connection}} and {{CassandraConnection}} were in order. Those changes drove a few casual additional changes in related classes {{CResultSet}}, {{CassandraStatement}} and {{CassandraPreparedStatement}} in order to continue to communicate properly. The class {{Utils}} was also enhanced to move more static utility methods into this holder class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2924) Consolidate JDBC driver
classes: Connection and CassandraConnection in advance of feature additions
for 1.1
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069350#comment-13069350 ]
Jonathan Ellis commented on CASSANDRA-2924:
-------------------------------------------
[committed w/ above changes]
> Consolidate JDBC driver classes: Connection and CassandraConnection in advance of feature additions for 1.1
> -----------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-2924
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2924
> Project: Cassandra
> Issue Type: Improvement
> Components: Drivers
> Affects Versions: 0.8.1
> Reporter: Rick Shaw
> Assignee: Rick Shaw
> Priority: Minor
> Labels: JDBC
> Fix For: 0.8.3
>
> Attachments: 2924-v2.txt, consolidate-connection-v1.txt
>
>
> For the JDBC Driver suite, additional cleanup and consolidation of classes {{Connection}} and {{CassandraConnection}} were in order. Those changes drove a few casual additional changes in related classes {{CResultSet}}, {{CassandraStatement}} and {{CassandraPreparedStatement}} in order to continue to communicate properly. The class {{Utils}} was also enhanced to move more static utility methods into this holder class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2924) Consolidate JDBC driver classes:
Connection and CassandraConnection in advance of feature additions for 1.1
Posted by "Rick Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rick Shaw updated CASSANDRA-2924:
---------------------------------
Attachment: consolidate-connection-v1.txt
> Consolidate JDBC driver classes: Connection and CassandraConnection in advance of feature additions for 1.1
> -----------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-2924
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2924
> Project: Cassandra
> Issue Type: Improvement
> Components: Drivers
> Affects Versions: 0.8.1
> Reporter: Rick Shaw
> Priority: Minor
> Labels: JDBC
> Fix For: 0.8.2
>
> Attachments: consolidate-connection-v1.txt
>
>
> For the JDBC Driver suite, additional cleanup and consolidation of classes {{Connection}} and {{CassandraConnection}} were in order. Those changes drove a few casual additional changes in related classes {{CResultSet}}, {{CassandraStatement}} and {{CassandraPreparedStatement}} in order to continue to communicate properly. The class {{Utils}} was also enhanced to move more static utility methods into this holder class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2924) Consolidate JDBC driver
classes: Connection and CassandraConnection in advance of feature additions
for 1.1
Posted by "Rick Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068927#comment-13068927 ]
Rick Shaw commented on CASSANDRA-2924:
--------------------------------------
+1
(lesson learned)
> Consolidate JDBC driver classes: Connection and CassandraConnection in advance of feature additions for 1.1
> -----------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-2924
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2924
> Project: Cassandra
> Issue Type: Improvement
> Components: Drivers
> Affects Versions: 0.8.1
> Reporter: Rick Shaw
> Assignee: Rick Shaw
> Priority: Minor
> Labels: JDBC
> Fix For: 0.8.2
>
> Attachments: 2924-v2.txt, consolidate-connection-v1.txt
>
>
> For the JDBC Driver suite, additional cleanup and consolidation of classes {{Connection}} and {{CassandraConnection}} were in order. Those changes drove a few casual additional changes in related classes {{CResultSet}}, {{CassandraStatement}} and {{CassandraPreparedStatement}} in order to continue to communicate properly. The class {{Utils}} was also enhanced to move more static utility methods into this holder class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2924) Consolidate JDBC driver
classes: Connection and CassandraConnection in advance of feature additions
for 1.1
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069199#comment-13069199 ]
Jonathan Ellis commented on CASSANDRA-2924:
-------------------------------------------
Why is ThriftConnection introduced?
> Consolidate JDBC driver classes: Connection and CassandraConnection in advance of feature additions for 1.1
> -----------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-2924
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2924
> Project: Cassandra
> Issue Type: Improvement
> Components: Drivers
> Affects Versions: 0.8.1
> Reporter: Rick Shaw
> Assignee: Rick Shaw
> Priority: Minor
> Labels: JDBC
> Fix For: 0.8.3
>
> Attachments: 2924-v2.txt, consolidate-connection-v1.txt
>
>
> For the JDBC Driver suite, additional cleanup and consolidation of classes {{Connection}} and {{CassandraConnection}} were in order. Those changes drove a few casual additional changes in related classes {{CResultSet}}, {{CassandraStatement}} and {{CassandraPreparedStatement}} in order to continue to communicate properly. The class {{Utils}} was also enhanced to move more static utility methods into this holder class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2924) Consolidate JDBC driver
classes: Connection and CassandraConnection in advance of feature additions
for 1.1
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068785#comment-13068785 ]
Jonathan Ellis commented on CASSANDRA-2924:
-------------------------------------------
Is that a +1?
> Consolidate JDBC driver classes: Connection and CassandraConnection in advance of feature additions for 1.1
> -----------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-2924
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2924
> Project: Cassandra
> Issue Type: Improvement
> Components: Drivers
> Affects Versions: 0.8.1
> Reporter: Rick Shaw
> Assignee: Rick Shaw
> Priority: Minor
> Labels: JDBC
> Fix For: 0.8.2
>
> Attachments: 2924-v2.txt, consolidate-connection-v1.txt
>
>
> For the JDBC Driver suite, additional cleanup and consolidation of classes {{Connection}} and {{CassandraConnection}} were in order. Those changes drove a few casual additional changes in related classes {{CResultSet}}, {{CassandraStatement}} and {{CassandraPreparedStatement}} in order to continue to communicate properly. The class {{Utils}} was also enhanced to move more static utility methods into this holder class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2924) Consolidate JDBC driver classes:
Connection and CassandraConnection in advance of feature additions for 1.1
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2924:
--------------------------------------
Attachment: 2924-v2.txt
v2 attached:
- adds test fixes + extra tests from CASSANDRA-2859
- re-standardizes formatting
Half a dozen of the static final String error messages in Utils are no longer used (one reason I prefer to leave them inlined).
> Consolidate JDBC driver classes: Connection and CassandraConnection in advance of feature additions for 1.1
> -----------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-2924
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2924
> Project: Cassandra
> Issue Type: Improvement
> Components: Drivers
> Affects Versions: 0.8.1
> Reporter: Rick Shaw
> Assignee: Rick Shaw
> Priority: Minor
> Labels: JDBC
> Fix For: 0.8.2
>
> Attachments: 2924-v2.txt, consolidate-connection-v1.txt
>
>
> For the JDBC Driver suite, additional cleanup and consolidation of classes {{Connection}} and {{CassandraConnection}} were in order. Those changes drove a few casual additional changes in related classes {{CResultSet}}, {{CassandraStatement}} and {{CassandraPreparedStatement}} in order to continue to communicate properly. The class {{Utils}} was also enhanced to move more static utility methods into this holder class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2924) Consolidate JDBC driver
classes: Connection and CassandraConnection in advance of feature additions
for 1.1
Posted by "Rick Shaw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069284#comment-13069284 ]
Rick Shaw commented on CASSANDRA-2924:
--------------------------------------
It defines the methods that are to be implemented over and above those required by the {{java.sql.Connection}} interface; these moved from the {{o.a.c.cql.jdbc.Connection}}. That class can now be removed. (I did not know how to do that in the patch?) I thought that seemed like the right thing to do (defining an interface) but it is not necessary.
> Consolidate JDBC driver classes: Connection and CassandraConnection in advance of feature additions for 1.1
> -----------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-2924
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2924
> Project: Cassandra
> Issue Type: Improvement
> Components: Drivers
> Affects Versions: 0.8.1
> Reporter: Rick Shaw
> Assignee: Rick Shaw
> Priority: Minor
> Labels: JDBC
> Fix For: 0.8.3
>
> Attachments: 2924-v2.txt, consolidate-connection-v1.txt
>
>
> For the JDBC Driver suite, additional cleanup and consolidation of classes {{Connection}} and {{CassandraConnection}} were in order. Those changes drove a few casual additional changes in related classes {{CResultSet}}, {{CassandraStatement}} and {{CassandraPreparedStatement}} in order to continue to communicate properly. The class {{Utils}} was also enhanced to move more static utility methods into this holder class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira