You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/11/16 23:49:26 UTC
[kudu-CR] java-client: fix test execution-order race in TestKuduTable
Hello Jean-Daniel Cryans,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5113
to review the following change.
Change subject: java-client: fix test execution-order race in TestKuduTable
......................................................................
java-client: fix test execution-order race in TestKuduTable
The test was checking the number of tables in the mini cluster, not
accounting for tables potentially leaked by other test cases.
Change-Id: I935a800d3d87ab2c3180ce589e1b6b5dd48f9d70
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/5113/1
--
To view, visit http://gerrit.cloudera.org:8080/5113
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I935a800d3d87ab2c3180ce589e1b6b5dd48f9d70
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
[kudu-CR] java-client: fix test execution-order race in TestKuduTable
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: java-client: fix test execution-order race in TestKuduTable
......................................................................
java-client: fix test execution-order race in TestKuduTable
The test was checking the number of tables in the mini cluster, not
accounting for tables potentially leaked by other test cases.
Change-Id: I935a800d3d87ab2c3180ce589e1b6b5dd48f9d70
Reviewed-on: http://gerrit.cloudera.org:8080/5113
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5113
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I935a800d3d87ab2c3180ce589e1b6b5dd48f9d70
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] java-client: fix test execution-order race in TestKuduTable
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: java-client: fix test execution-order race in TestKuduTable
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5113
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I935a800d3d87ab2c3180ce589e1b6b5dd48f9d70
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No