You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2023/02/14 01:36:14 UTC

[GitHub] [parquet-mr] wgtmac commented on a diff in pull request #1025: PARQUET-2241: Fix ByteStreamSplitValuesReader with nulls

wgtmac commented on code in PR #1025:
URL: https://github.com/apache/parquet-mr/pull/1025#discussion_r1105198239


##########
parquet-column/src/main/java/org/apache/parquet/column/values/bytestreamsplit/ByteStreamSplitValuesReader.java:
##########
@@ -58,15 +58,19 @@ protected void gatherElementDataFromStreams(byte[] gatheredData)
   public void initFromPage(int valuesCount, ByteBufferInputStream stream) throws ParquetDecodingException, IOException {

Review Comment:
   Added a check to use `valuesCount` as upper bound.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org