You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/02 17:54:22 UTC
[GitHub] [spark] techaddict opened a new pull request, #39346: [SPARK-41656][CONNECT] Enable doctests in pyspark.sql.connect.dataframe
techaddict opened a new pull request, #39346:
URL: https://github.com/apache/spark/pull/39346
### What changes were proposed in this pull request?
This PR proposes to enable doctests in pyspark.sql.connect.dataframe that is virtually the same as pyspark.sql.dataframe.
### Why are the changes needed?
To make sure on the PySpark compatibility and test coverage.
### Does this PR introduce any user-facing change?
No, doctest's only.
### How was this patch tested?
New Doctests Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39346: [SPARK-41656][CONNECT] Enable doctests in pyspark.sql.connect.dataframe
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39346:
URL: https://github.com/apache/spark/pull/39346#issuecomment-1369298881
@techaddict mind resolving conflicts? Otherwise good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #39346: [SPARK-41656][CONNECT][TESTS] Enable doctests in pyspark.sql.connect.dataframe
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #39346: [SPARK-41656][CONNECT][TESTS] Enable doctests in pyspark.sql.connect.dataframe
URL: https://github.com/apache/spark/pull/39346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39346: [SPARK-41656][CONNECT][TESTS] Enable doctests in pyspark.sql.connect.dataframe
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39346:
URL: https://github.com/apache/spark/pull/39346#issuecomment-1369325330
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org