[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1365: DISPATCH-2246 Use port 0 in systemtests when starting TCP_echo_server, then query for actual port

[GitBox <gi...@apache.org>]

jiridanek commented on a change in pull request #1365:
URL: https://github.com/apache/qpid-dispatch/pull/1365#discussion_r704821655



##########
File path: tests/system_tests_tcp_adaptor.py
##########
@@ -347,12 +342,12 @@ def router(name, mode, connection, extra=None):
                                    ofilename=os.path.join(parent_path, "setUpClass/TcpAdaptor_echo_server_%s.log" % rtr))
             cls.logger.log("TCP_TEST Launching echo server '%s'" % server_prefix)
             server = TcpEchoServer(prefix=server_prefix,
-                                   port=cls.tcp_server_listener_ports[rtr],
+                                   port=0,
                                    logger=server_logger)
             assert server.is_running

Review comment:
       Previously, this suffered from a race condition; what if the new thread took its time setting this variable?
   
   Not that I ever saw this specific assert to fail, to be honest.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org