[GitHub] [couchdb] bessbd opened a new pull request #3415: Remove error message on mix test

[GitBox <gi...@apache.org>]

bessbd opened a new pull request #3415:
URL: https://github.com/apache/couchdb/pull/3415


   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   
   All `mix test` runs were starting with
   ```
   Cannot configure base applications: [:kernel]
   
   These applications are already started by the time the configuration
   executes and these configurations have no effect.
   
   If you want to configure these applications for a release, you can
   specify them in your vm.args file:
   
       -kernel config_key config_value
   
   Alternatively, if you must configure them dynamically, you can wrap
   them in a conditional block in your config files:
   
       if System.get_env("RELEASE_MODE") do
         config :kernel, ...
       end
   
   and then configure your releases to reboot after configuration:
   
       releases: [
         my_app: [reboot_system_after_config: true]
       ]
   
   This happened when loading config/config.exs or
   one of its imports.
   ```
   
   I haven't been able to find references to `Mix.Config`'s `error_logger` in `kernel` so I've opened this PR to remove it.
   I understand this is probably a [Chesterton's fence](https://en.wikipedia.org/wiki/G._K._Chesterton#Chesterton's_fence) so I'm okay with keeping it, but I'd prefer this PR be `-1`d with a reference to why those lines need to stay. +CC @iilyak (`git blame` tells me it was introduced in d427f353ab4be03998685f6a167d9559c7b50a76 ).
   
   ## Testing recommendations
   
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   
   ## Related Issues or Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [ ] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] janl merged pull request #3415: Remove error message on mix test

[GitBox <gi...@apache.org>]

janl merged pull request #3415:
URL: https://github.com/apache/couchdb/pull/3415


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] bessbd commented on pull request #3415: Remove error message on mix test

[GitBox <gi...@apache.org>]

bessbd commented on pull request #3415:
URL: https://github.com/apache/couchdb/pull/3415#issuecomment-800099229


   Thank you for the review and merge, @janl !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org