[GitHub] [airflow] potiuk commented on a change in pull request #5673: [AIRFLOW-4451] Allow templated named tuples

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #5673: [AIRFLOW-4451] Allow templated named tuples
URL: https://github.com/apache/airflow/pull/5673#discussion_r308004916
 
 

 ##########
 File path: tests/operators/test_python_operator.py
 ##########
 @@ -163,7 +170,8 @@ def test_python_callable_arguments_are_templatized(self):
             recorded_calls[0],
             Call(4,
                  date(2019, 1, 1),
-                 "dag {} ran on {}.".format(self.dag.dag_id, DEFAULT_DATE.date().isoformat()))
+                 "dag {} ran on {}.".format(self.dag.dag_id, DEFAULT_DATE.date().isoformat()),
 
 Review comment:
   I think we should add a test when the named tuple's  value will contain jinja's  template '{{}}', For now we just check that the named tuple is preserved, not that the template resolution works in the tuple. 
   
   Also I think it would be great to separate test that only tests template rendering. Maybe that's the right time. I don't think we have such test ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services