You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lc...@apache.org on 2017/11/01 17:47:06 UTC
[1/2] beam git commit: Remove obsolete extra parameter
Repository: beam
Updated Branches:
refs/heads/master b743ab10d -> b013d7c5a
Remove obsolete extra parameter
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/64437549
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/64437549
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/64437549
Branch: refs/heads/master
Commit: 64437549540d72dd11c10944f0175df4efa0a81b
Parents: b743ab1
Author: Rafal Wojdyla <ra...@spotify.com>
Authored: Mon Oct 30 21:58:24 2017 -0400
Committer: Luke Cwik <lc...@google.com>
Committed: Wed Nov 1 10:46:24 2017 -0700
----------------------------------------------------------------------
.../org/apache/beam/sdk/transforms/join/CoGbkResult.java | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/beam/blob/64437549/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/join/CoGbkResult.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/join/CoGbkResult.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/join/CoGbkResult.java
index 16a0bae..1dad9f4 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/join/CoGbkResult.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/join/CoGbkResult.java
@@ -117,15 +117,13 @@ public class CoGbkResult {
// against a given tag would not match anything.
final Boolean[] containsTag = new Boolean[schema.size()];
for (int unionTag = 0; unionTag < schema.size(); unionTag++) {
- final int unionTag0 = unionTag;
- updateUnionTag(tail, containsTag, unionTag, unionTag0);
+ updateUnionTag(tail, containsTag, unionTag);
}
}
}
private <T> void updateUnionTag(
- final Reiterator<RawUnionValue> tail, final Boolean[] containsTag,
- int unionTag, final int unionTag0) {
+ final Reiterator<RawUnionValue> tail, final Boolean[] containsTag, final int unionTag) {
@SuppressWarnings("unchecked")
final Iterable<T> head = (Iterable<T>) valueMap.get(unionTag);
valueMap.set(
@@ -135,7 +133,7 @@ public class CoGbkResult {
public Iterator<T> iterator() {
return Iterators.concat(
head.iterator(),
- new UnionValueIterator<T>(unionTag0, tail.copy(), containsTag));
+ new UnionValueIterator<T>(unionTag, tail.copy(), containsTag));
}
});
}
[2/2] beam git commit: Remove obsolete extra parameter
Posted by lc...@apache.org.
Remove obsolete extra parameter
This closes #4061
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/b013d7c5
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/b013d7c5
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/b013d7c5
Branch: refs/heads/master
Commit: b013d7c5a35b81ae988dc0625fa15a0df21eba5a
Parents: b743ab1 6443754
Author: Luke Cwik <lc...@google.com>
Authored: Wed Nov 1 10:46:52 2017 -0700
Committer: Luke Cwik <lc...@google.com>
Committed: Wed Nov 1 10:46:52 2017 -0700
----------------------------------------------------------------------
.../org/apache/beam/sdk/transforms/join/CoGbkResult.java | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
----------------------------------------------------------------------