You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2024/02/09 08:37:04 UTC
[Impala-ASF-CR] IMPALA-12795: Deflake test catalog operation fields
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21023
Change subject: IMPALA-12795: Deflake test_catalog_operation_fields
......................................................................
IMPALA-12795: Deflake test_catalog_operation_fields
test_catalog_operation_fields verifies the CREATE DATABASE statement has
consistent fields in the catalog operations page and the impalad queries
page. It could fail if the query is waiting to be closed (so not in the
list of completed queries). This fix the test by also finding the query
in the list of in-flight queries.
Tests:
- Ran the test 18000 times with other concurrent tests running
Change-Id: Ibc8e642d560c1a4ca1bdc3a618eb67e1329b47d2
---
M tests/webserver/test_web_pages.py
1 file changed, 32 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/21023/1
--
To view, visit http://gerrit.cloudera.org:8080/21023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc8e642d560c1a4ca1bdc3a618eb67e1329b47d2
Gerrit-Change-Number: 21023
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12795: Deflake test catalog operation fields
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21023 )
Change subject: IMPALA-12795: Deflake test_catalog_operation_fields
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15225/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8e642d560c1a4ca1bdc3a618eb67e1329b47d2
Gerrit-Change-Number: 21023
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 10 Feb 2024 01:08:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12795: Deflake test catalog operation fields
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21023 )
Change subject: IMPALA-12795: Deflake test_catalog_operation_fields
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8e642d560c1a4ca1bdc3a618eb67e1329b47d2
Gerrit-Change-Number: 21023
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 11 Feb 2024 15:07:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12795: Deflake test catalog operation fields
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21023
to look at the new patch set (#2).
Change subject: IMPALA-12795: Deflake test_catalog_operation_fields
......................................................................
IMPALA-12795: Deflake test_catalog_operation_fields
test_catalog_operation_fields verifies the CREATE DATABASE statement has
consistent fields in the catalog operations page and the impalad queries
page. It could fail if the query is waiting to be closed (so not in the
list of completed queries). This fix the test by also finding the query
in the list of in-flight queries.
Tests:
- Ran the test 18000 times with other concurrent tests running
Change-Id: Ibc8e642d560c1a4ca1bdc3a618eb67e1329b47d2
---
M tests/webserver/test_web_pages.py
1 file changed, 33 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/21023/2
--
To view, visit http://gerrit.cloudera.org:8080/21023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc8e642d560c1a4ca1bdc3a618eb67e1329b47d2
Gerrit-Change-Number: 21023
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-12795: Deflake test catalog operation fields
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21023 )
Change subject: IMPALA-12795: Deflake test_catalog_operation_fields
......................................................................
IMPALA-12795: Deflake test_catalog_operation_fields
test_catalog_operation_fields verifies the CREATE DATABASE statement has
consistent fields in the catalog operations page and the impalad queries
page. It could fail if the query is waiting to be closed (so not in the
list of completed queries). This fix the test by also finding the query
in the list of in-flight queries.
Tests:
- Ran the test 18000 times with other concurrent tests running
Change-Id: Ibc8e642d560c1a4ca1bdc3a618eb67e1329b47d2
Reviewed-on: http://gerrit.cloudera.org:8080/21023
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/webserver/test_web_pages.py
1 file changed, 33 insertions(+), 10 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc8e642d560c1a4ca1bdc3a618eb67e1329b47d2
Gerrit-Change-Number: 21023
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-12795: Deflake test catalog operation fields
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21023 )
Change subject: IMPALA-12795: Deflake test_catalog_operation_fields
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21023/1/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:
http://gerrit.cloudera.org:8080/#/c/21023/1/tests/webserver/test_web_pages.py@951
PS1, Line 951: e
flake8: E501 line too long (98 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/21023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8e642d560c1a4ca1bdc3a618eb67e1329b47d2
Gerrit-Change-Number: 21023
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Feb 2024 08:38:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12795: Deflake test catalog operation fields
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21023 )
Change subject: IMPALA-12795: Deflake test_catalog_operation_fields
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10266/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8e642d560c1a4ca1bdc3a618eb67e1329b47d2
Gerrit-Change-Number: 21023
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 11 Feb 2024 15:08:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12795: Deflake test catalog operation fields
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21023 )
Change subject: IMPALA-12795: Deflake test_catalog_operation_fields
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/15216/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8e642d560c1a4ca1bdc3a618eb67e1329b47d2
Gerrit-Change-Number: 21023
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Feb 2024 09:03:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12795: Deflake test catalog operation fields
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21023 )
Change subject: IMPALA-12795: Deflake test_catalog_operation_fields
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8e642d560c1a4ca1bdc3a618eb67e1329b47d2
Gerrit-Change-Number: 21023
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 11 Feb 2024 15:08:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12795: Deflake test catalog operation fields
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21023 )
Change subject: IMPALA-12795: Deflake test_catalog_operation_fields
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc8e642d560c1a4ca1bdc3a618eb67e1329b47d2
Gerrit-Change-Number: 21023
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Sun, 11 Feb 2024 19:44:43 +0000
Gerrit-HasComments: No