[GitHub] [iceberg] kbendick commented on a diff in pull request #5389: Python: Refactor expression hierarchy

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #5389:
URL: https://github.com/apache/iceberg/pull/5389#discussion_r933722872


##########
python/pyiceberg/expressions/base.py:
##########
@@ -99,8 +93,12 @@ def ref(self) -> BoundReference[T]:
         return self
 
 
+class UnboundTerm(Term[T], Unbound[BoundTerm[T]], ABC):

Review Comment:
   Nit / non-blocking: An `Unbound[BoundTerm[T]]` is somewhat of a confusing type signature (particularly coming more from the Java side).
   
   However `UnboundTerm` itself is clear as day so that's not particularly a concern.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org