You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/04 10:23:10 UTC
[GitHub] maropu removed a comment on issue #23731: [SPARK-26572][SQL] fix
aggregate codegen result evaluation
maropu removed a comment on issue #23731: [SPARK-26572][SQL] fix aggregate codegen result evaluation
URL: https://github.com/apache/spark/pull/23731#issuecomment-460194935
But, the current fix changes the behaivour of the other stateful exprs, too? e.g.,
```
scala> val baseTable = Seq((1), (1)).toDF("idx")
scala> val distinctWithRandId = baseTable.distinct.withColumn("id", functions.rand())
scala> baseTable.join(distinctWithRandId, "idx").show
// w/ this pr
+---+-------------------+
|idx| id|
+---+-------------------+
| 1|0.09884607470357032|
| 1|0.09884607470357032|
+---+-------------------+
// the current master
scala> baseTable.join(distinctWithRandId, "idx").show
+---+-------------------+
|idx| id|
+---+-------------------+
| 1|0.08661806632196123|
| 1| 0.0903755555098934|
+---+-------------------+
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org