Re: Review Request 21431: CLOUDSTACK-6665: A fix for vpc routers not releasing dhcp leases.

[Sebastien Goasguen <ru...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21431/#review47059
-----------------------------------------------------------


CLOUDSTACK-6665 says this is a problem in 4.3, but this patch only applies to 4.4.
Could you provide a patch for 4.3 ?

thanks

- Sebastien Goasguen


On May 20, 2014, 9:05 a.m., Joris van Lieshout wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21431/
> -----------------------------------------------------------
> 
> (Updated May 20, 2014, 9:05 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland, Hugo Trippaers, and Sheng Yang.
> 
> 
> Bugs: cloudstack-6665
>     https://issues.apache.org/jira/browse/cloudstack-6665
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The releasing of dhcp leases on vpc routers fails because the network on which the instance that holds the lease lives is not behind eth0, like with normal router vms. The current code assumes eth0, this patch will make interface selection dynamic based on the ipv4 address of the instance.
> 
> 
> Diffs
> -----
> 
>   systemvm/patches/debian/config/opt/cloud/bin/edithosts.sh c1046c6 
> 
> Diff: https://reviews.apache.org/r/21431/diff/
> 
> 
> Testing
> -------
> 
> Tested on vpc routers in our own environment. Manual workaround for vpc experiencing this issue was to execute the command in this patch by hand.
> 
> 
> Thanks,
> 
> Joris van Lieshout
> 
>