You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "emilk (via GitHub)" <gi...@apache.org> on 2026/08/18 04:55:39 UTC
[PR] Enable even more clippy lints [arrow-rs]
emilk opened a new pull request, #10721:
URL: https://github.com/apache/arrow-rs/pull/10721
# Which issue does this PR close?
No issue in particular
- Follow-up to #10673
# Rationale for this change
The last of the lints hand-picked from [egui's `Cargo.toml`](https://github.com/emilk/egui/blob/main/Cargo.toml). These eight need more churn than the earlier batches, so they were left out of #10673.
## What changes are included in this PR?
One commit per new lint (easiest to review commit by commit!): `uninlined_format_args`, `from_iter_instead_of_collect`, `unnecessary_semicolon`, `elidable_lifetime_names`, `string_lit_as_bytes`, `manual_let_else`, `return_and_then`, `derive_partial_eq_without_eq`.
Let me know if you disagree with any of them. `return_and_then` is the one I am least sure about: a few sites read better as a chain, a few read worse.
The generated `arrow-ipc/src/gen` and prost modules are exempt from `derive_partial_eq_without_eq` rather than edited.
## Are these changes tested?
Covered by existing tests plus the clippy CI job.
## Are there any user-facing changes?
One additive change: `derive_partial_eq_without_eq` adds `Eq` next to `PartialEq` on public types in `arrow-array`, `arrow-avro`, `arrow-flight`, `arrow-schema`, `parquet` and `parquet-variant`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable even more clippy lints [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #10721:
URL: https://github.com/apache/arrow-rs/pull/10721#issuecomment-5326067202
thanks @emilk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable even more clippy lints [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #10721:
URL: https://github.com/apache/arrow-rs/pull/10721#issuecomment-5334449577
CI is failing on main due to a small logical conflict with this PR. I have a fix for it:
- https://github.com/apache/arrow-rs/pull/10743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable even more clippy lints [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #10721:
URL: https://github.com/apache/arrow-rs/pull/10721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Enable even more clippy lints [arrow-rs]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #10721:
URL: https://github.com/apache/arrow-rs/pull/10721#issuecomment-5324608046
maybe the `clippy::derive_partial_eq_without_eq` one should be split out into a separate PR as it might need more consideration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org