[GitHub] [superset] betodealmeida commented on a change in pull request #19261: chore: remove old alerts and configs keys

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #19261:
URL: https://github.com/apache/superset/pull/19261#discussion_r833786370



##########
File path: superset/views/alerts.py
##########
@@ -17,73 +17,19 @@
 """
 DEPRECATION NOTICE: this module is deprecated and will be removed on 2.0.
 """

Review comment:
       If we're not getting rid of `AlertView` let's removing this notice.

##########
File path: superset/views/alerts.py
##########
@@ -109,144 +55,3 @@ def log(self, pk: int) -> FlaskResponse:  # pylint: disable=unused-argument
 class AlertView(BaseAlertReportView):
     route_base = "/alert"
     class_permission_name = "ReportSchedule"

Review comment:
       Are these 2 classes still being used?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org