You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/06/18 02:16:04 UTC
[GitHub] [kafka] kkonstantine opened a new pull request #8893: MINOR: Upgrade jetty to 9.4.30.v20200611
kkonstantine opened a new pull request #8893:
URL: https://github.com/apache/kafka/pull/8893
Recently commit 492306a updated both jetty to version 9.4.27.v20200227 and jersey to version 2.31
However in the latest versions of jetty, the renaming of the method `Response#closeOutput` to `Response#completeOutput` has been reverted, with the latest version using again `Response#closeOutput`.
Jersey has not released a recent version in which `Response#closeOutput` is called directly. In its latest version 2.31 `Response#closeOutput` will be called if `Response#completeOutput` throws a `NoSuchMethodError` exception, which keeps things functional but inefficient.
Therefore we can choose to merge this PR early, while waiting for a new version of jersey, or we could wait and update both dependencies together again.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kkonstantine merged pull request #8893: MINOR: Upgrade jetty to 9.4.30.v20200611
Posted by GitBox <gi...@apache.org>.
kkonstantine merged pull request #8893:
URL: https://github.com/apache/kafka/pull/8893
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kkonstantine commented on pull request #8893: MINOR: Upgrade jetty to 9.4.30.v20200611
Posted by GitBox <gi...@apache.org>.
kkonstantine commented on pull request #8893:
URL: https://github.com/apache/kafka/pull/8893#issuecomment-645727688
cc @ijuma @rhauch @C0urante
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kkonstantine commented on pull request #8893: MINOR: Upgrade jetty to 9.4.30.v20200611
Posted by GitBox <gi...@apache.org>.
kkonstantine commented on pull request #8893:
URL: https://github.com/apache/kafka/pull/8893#issuecomment-645733448
The current use in jersey can be found [here](https://github.com/eclipse-ee4j/jersey/blob/master/containers/jetty-http/src/main/java/org/glassfish/jersey/jetty/JettyHttpContainer.java#L339-L353)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kkonstantine commented on pull request #8893: MINOR: Upgrade jetty to 9.4.30.v20200611
Posted by GitBox <gi...@apache.org>.
kkonstantine commented on pull request #8893:
URL: https://github.com/apache/kafka/pull/8893#issuecomment-651258204
2/3 builds are green, while the other one failed with 3 flaky MM2 tests.
Thanks @ijuma
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #8893: MINOR: Upgrade jetty to 9.4.30.v20200611
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #8893:
URL: https://github.com/apache/kafka/pull/8893#issuecomment-650788296
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org