You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "john-bodley (via GitHub)" <gi...@apache.org> on 2023/02/21 22:06:13 UTC
[GitHub] [superset] john-bodley opened a new pull request, #23142: chore: Remove the ability to add filter-box charts when DASHBOARD_NATIVE_FILTERS feature is enabled
john-bodley opened a new pull request, #23142:
URL: https://github.com/apache/superset/pull/23142
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
This PR addresses recommendation #⁠4 in https://github.com/apache/superset/issues/14383, i.e., it prevents:
1. A new filter-box visualization type chart being created;
2. An existing filter-box visualization type neing added to a dashboard (either via the edit dashboard or save chart workflow)
if the `DASHBOARD_NATIVE_FILTERS` filter flag is enabled. Note the export/import dashboard workflow has not been augmented from a preservation standpoint.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
#### BEFORE
<img width="978" alt="Screenshot 2023-02-22 at 10 56 03 AM" src="https://user-images.githubusercontent.com/4567245/220468823-93aae6a0-2a65-44b1-9771-7acf43e924a2.png">
<img width="537" alt="Screenshot 2023-02-22 at 10 56 18 AM" src="https://user-images.githubusercontent.com/4567245/220468813-79e773e7-acfd-4af4-951b-202334cfa387.png">
<img width="334" alt="Screenshot 2023-02-22 at 10 55 44 AM" src="https://user-images.githubusercontent.com/4567245/220468829-95cf821f-914e-4e32-bb4a-f05b0f53a8b2.png">
#### AFTER
<img width="976" alt="Screenshot 2023-02-22 at 10 50 37 AM" src="https://user-images.githubusercontent.com/4567245/220469054-33ecd515-a638-4691-82a8-c954eaf56b95.png">
<img width="334" alt="Screenshot 2023-02-22 at 10 51 04 AM" src="https://user-images.githubusercontent.com/4567245/220469050-b4449685-ec3a-4ee2-930e-829d3f9c0604.png">
<img width="539" alt="Screenshot 2023-02-22 at 10 48 16 AM" src="https://user-images.githubusercontent.com/4567245/220469061-98b244f2-a5ad-4815-99e9-3be1b168cc4d.png">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23142: chore: Remove the ability to add filter-box charts when DASHBOARD_NATIVE_FILTERS feature is enabled
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23142:
URL: https://github.com/apache/superset/pull/23142#issuecomment-1439310877
# [Codecov](https://codecov.io/gh/apache/superset/pull/23142?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23142](https://codecov.io/gh/apache/superset/pull/23142?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b58c2c) into [master](https://codecov.io/gh/apache/superset/commit/eb8386e3f0647df6d1bbde8b42073850796cc16f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eb8386e) will **increase** coverage by `1.67%`.
> The diff coverage is `59.42%`.
> :exclamation: Current head 1b58c2c differs from pull request most recent head 636c54f. Consider uploading reports for the commit 636c54f to get more accurate results
```diff
@@ Coverage Diff @@
## master #23142 +/- ##
==========================================
+ Coverage 65.81% 67.48% +1.67%
==========================================
Files 1881 1898 +17
Lines 72398 73078 +680
Branches 7882 7949 +67
==========================================
+ Hits 47647 49320 +1673
+ Misses 22729 21718 -1011
- Partials 2022 2040 +18
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.67% <27.49%> (-0.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ackages/superset-ui-core/src/utils/featureFlags.ts](https://codecov.io/gh/apache/superset/pull/23142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvZmVhdHVyZUZsYWdzLnRz) | `100.00% <ø> (ø)` | |
| [...uperset-frontend/src/pages/ChartCreation/index.tsx](https://codecov.io/gh/apache/superset/pull/23142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0NoYXJ0Q3JlYXRpb24vaW5kZXgudHN4) | `58.62% <0.00%> (-3.20%)` | :arrow_down: |
| [...rontend/src/views/CRUD/allentities/AllEntities.tsx](https://codecov.io/gh/apache/superset/pull/23142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxsZW50aXRpZXMvQWxsRW50aXRpZXMudHN4) | `0.00% <0.00%> (ø)` | |
| [...nd/src/views/CRUD/allentities/AllEntitiesTable.tsx](https://codecov.io/gh/apache/superset/pull/23142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxsZW50aXRpZXMvQWxsRW50aXRpZXNUYWJsZS50c3g=) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/views/CRUD/tags/TagCard.tsx](https://codecov.io/gh/apache/superset/pull/23142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdGFncy9UYWdDYXJkLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/views/CRUD/tags/TagList.tsx](https://codecov.io/gh/apache/superset/pull/23142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdGFncy9UYWdMaXN0LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/23142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/tags.ts](https://codecov.io/gh/apache/superset/pull/23142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3RhZ3MudHM=) | `13.72% <13.72%> (ø)` | |
| [superset-frontend/src/components/Tags/utils.tsx](https://codecov.io/gh/apache/superset/pull/23142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFncy91dGlscy50c3g=) | `21.05% <21.05%> (ø)` | |
| [...d/src/explore/components/PropertiesModal/index.tsx](https://codecov.io/gh/apache/superset/pull/23142?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwvaW5kZXgudHN4) | `50.53% <25.80%> (-12.37%)` | :arrow_down: |
| ... and [133 more](https://codecov.io/gh/apache/superset/pull/23142?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley merged pull request #23142: chore: Remove the ability to add filter-box charts when DASHBOARD_NATIVE_FILTERS feature is enabled
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley merged PR #23142:
URL: https://github.com/apache/superset/pull/23142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Antonio-RiveroMartnez commented on a diff in pull request #23142: chore: Remove the ability to add filter-box charts when DASHBOARD_NATIVE_FILTERS feature is enabled
Posted by "Antonio-RiveroMartnez (via GitHub)" <gi...@apache.org>.
Antonio-RiveroMartnez commented on code in PR #23142:
URL: https://github.com/apache/superset/pull/23142#discussion_r1114698776
##########
superset-frontend/src/dashboard/actions/sliceEntities.js:
##########
@@ -56,6 +57,16 @@ export function fetchSlices(
? [{ col: 'slice_name', opr: 'chart_all_text', value: filter_value }]
: [];
+ if (isFeatureEnabled(FeatureFlag.DASHBOARD_NATIVE_FILTERS)) {
+ additional_filters.push({
+ col: 'viz_type',
+ opr: 'neq',
+ value: 'filter_box',
+ });
+ }
+
+ isFeatureEnabled(FeatureFlag.DASHBOARD_NATIVE_FILTERS);
Review Comment:
Should be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org