[GitHub] [druid] somu-imply commented on a diff in pull request #13173: Fix row schema of nested queries to get proper row type during planning validation

[GitBox <gi...@apache.org>]

somu-imply commented on code in PR #13173:
URL: https://github.com/apache/druid/pull/13173#discussion_r989521087


##########
sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidQuery.java:
##########
@@ -1298,15 +1298,6 @@ private ScanQuery toScanQuery()
         );
         return null;
       }
-      if (!dataSource.isConcrete()) {

Review Comment:
   This was introduced during #12418 as we moved to using a QueryDataSource. A TableDataSource always return true for `isConcrete`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org