You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/02/06 18:42:53 UTC
Review Request 17801: Bulk Component state changes need to skip PASSIVE
host_components
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17801/
-----------------------------------------------------------
Review request for Ambari, Sid Wagle and Tom Beerbower.
Bugs: AMBARI-4543
https://issues.apache.org/jira/browse/AMBARI-4543
Repository: ambari
Description
-------
* When changing the state of Components, any HostComponent that resolves to a PASSIVE or IMPLIED should be skipped.
* Additionally, client components should not be set to PASSIVE.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 2e1c3cd
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 5e9b3b4
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java f483068
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java a8770ac
Diff: https://reviews.apache.org/r/17801/diff/
Testing
-------
Running org.apache.ambari.server.controller.internal.ComponentResourceProviderTest
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.711 sec
Running org.apache.ambari.server.controller.AmbariManagementControllerTest
Tests run: 102, Failures: 0, Errors: 0, Skipped: 5, Time elapsed: 115.652 sec
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11:48.055s
[INFO] Finished at: Wed Feb 05 20:58:27 PST 2014
[INFO] Final Memory: 18M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 17801: Bulk Component state changes need to skip PASSIVE
host_components
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17801/#review33806
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On Feb. 6, 2014, 5:42 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17801/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2014, 5:42 p.m.)
>
>
> Review request for Ambari, Sid Wagle and Tom Beerbower.
>
>
> Bugs: AMBARI-4543
> https://issues.apache.org/jira/browse/AMBARI-4543
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * When changing the state of Components, any HostComponent that resolves to a PASSIVE or IMPLIED should be skipped.
> * Additionally, client components should not be set to PASSIVE.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 2e1c3cd
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java 5e9b3b4
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java f483068
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java a8770ac
>
> Diff: https://reviews.apache.org/r/17801/diff/
>
>
> Testing
> -------
>
> Running org.apache.ambari.server.controller.internal.ComponentResourceProviderTest
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.711 sec
>
> Running org.apache.ambari.server.controller.AmbariManagementControllerTest
> Tests run: 102, Failures: 0, Errors: 0, Skipped: 5, Time elapsed: 115.652 sec
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 11:48.055s
> [INFO] Finished at: Wed Feb 05 20:58:27 PST 2014
> [INFO] Final Memory: 18M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>