You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/29 20:32:19 UTC
[GitHub] [airflow] turbaszek opened a new pull request #12708: Add statsd integration to breeze
turbaszek opened a new pull request #12708:
URL: https://github.com/apache/airflow/pull/12708
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins commented on pull request #12708: Add statsd integration to breeze
Posted by GitBox <gi...@apache.org>.
jhtimmins commented on pull request #12708:
URL: https://github.com/apache/airflow/pull/12708#issuecomment-774591175
@turbaszek @potiuk Going back through older PRs. Is this still in progress?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12708: Add statsd integration to breeze
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12708:
URL: https://github.com/apache/airflow/pull/12708#issuecomment-774670379
MySQL and K8S failures are unrelated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #12708: Add statsd integration to breeze
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #12708:
URL: https://github.com/apache/airflow/pull/12708#discussion_r532290522
##########
File path: scripts/ci/docker-compose/integration-statsd.yml
##########
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+version: "2.2"
+services:
+ statsd-exporter:
+ image: prom/statsd-exporter
Review comment:
We are already using airffow''s version of the statsd exporter in the helm chart and it is published in airflow dockerhub published https://github.com/apache/airflow/blob/bb00f164da6c84f078e66582217832aeedb2a966/chart/values.yaml#L136
We also have our own way to build and publish it as needed (it is super-easy): https://github.com/apache/airflow/blob/master/chart/dockerfiles/statsd-exporter/build_and_push.sh
Shoud we use that version instead? Should we rebuild and push a new version instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #12708: Add statsd integration to breeze
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #12708:
URL: https://github.com/apache/airflow/pull/12708
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #12708: Add statsd integration to breeze
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #12708:
URL: https://github.com/apache/airflow/pull/12708#discussion_r532441822
##########
File path: scripts/ci/docker-compose/integration-statsd.yml
##########
@@ -0,0 +1,38 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+---
+version: "2.2"
+services:
+ statsd-exporter:
+ image: prom/statsd-exporter
Review comment:
Sure, didn't know that!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12708: Add statsd integration to breeze
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12708:
URL: https://github.com/apache/airflow/pull/12708#issuecomment-774670416
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on pull request #12708: Add statsd integration to breeze
Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #12708:
URL: https://github.com/apache/airflow/pull/12708#issuecomment-774667423
@jhtimmins I updated the PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org