[GitHub] [tvm] Archermmt commented on pull request #15489: [RFC][Unity][MSC] MileStone 0

["Archermmt (via GitHub)" <gi...@apache.org>]

Archermmt commented on PR #15489:
URL: https://github.com/apache/tvm/pull/15489#issuecomment-1666443937

   > Well I mean this is awesome to have MSC, but is there any way we could potentially split the PR to certain reviewable size?
   
   let me think of that. Maybe split it into some small parts as following:
   M0.1: Passes for set name and layout for expressions (src/contrib/msc/transform)
   M0.2: MSCGraph core (src/contrib/msc/core/ir/graph && python/tvm/contrib/msc/core/ir/graph)
   M0.3: MSCGraph Builder (src/contrib/msc/core/ir/graph_builder)
   M0.4: Codegen (src/contrib/msc/core/codegen, src/contrib/msc/framework/tvm/codegen)
   M0.5: Test (tests/python/contrib/test_msc && related helper modules in python)
   
   Each step is functional isolated and play as pre-request of next step. I can try add some test after each part.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org