You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/10/01 05:52:00 UTC
[GitHub] [incubator-pinot] jackjlli opened a new pull request #6088: Put Hadoop dependencies down to pinot-orc, pinot-parquet modules
jackjlli opened a new pull request #6088:
URL: https://github.com/apache/incubator-pinot/pull/6088
## Description
This PR puts Hadoop dependencies down to pinot-orc, pinot-parquet modules.
See the discussions in https://github.com/apache/incubator-pinot/pull/6070.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6088: Put Hadoop dependencies down to pinot-orc, pinot-parquet modules
Posted by GitBox <gi...@apache.org>.
jackjlli commented on a change in pull request #6088:
URL: https://github.com/apache/incubator-pinot/pull/6088#discussion_r502024417
##########
File path: pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/pom.xml
##########
@@ -119,6 +119,10 @@
<groupId>org.apache.pinot</groupId>
<artifactId>pinot-core</artifactId>
</exclusion>
+ <exclusion>
Review comment:
We are not gonna exclude all the `hadoop-common` from `pinot-hadoop`. `hadoop-client` still keeps the dependency of `hadoop-common`:
```
[INFO] -------------------< org.apache.pinot:pinot-hadoop >--------------------
[INFO] Building Pinot Hadoop 0.6.0-SNAPSHOT [35/46]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ pinot-hadoop ---
[INFO] org.apache.pinot:pinot-hadoop:jar:0.6.0-SNAPSHOT
[INFO] \- org.apache.hadoop:hadoop-client:jar:2.7.0:provided
[INFO] \- org.apache.hadoop:hadoop-common:jar:2.7.0:provided (scope managed from compile)
```
Plus, it'd always be good to exclude duplicate dependencies and keep only 1 in the pom file to avoiding introducing multiple versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli merged pull request #6088: Put Hadoop dependencies down to pinot-orc, pinot-parquet modules
Posted by GitBox <gi...@apache.org>.
jackjlli merged pull request #6088:
URL: https://github.com/apache/incubator-pinot/pull/6088
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6088: Put Hadoop dependencies down to pinot-orc, pinot-parquet modules
Posted by GitBox <gi...@apache.org>.
jackjlli commented on a change in pull request #6088:
URL: https://github.com/apache/incubator-pinot/pull/6088#discussion_r502024417
##########
File path: pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/pom.xml
##########
@@ -119,6 +119,10 @@
<groupId>org.apache.pinot</groupId>
<artifactId>pinot-core</artifactId>
</exclusion>
+ <exclusion>
Review comment:
We are not gonna exclude all the `hadoop-common` from `pinot-hadoop`. `hadoop-client` keeps the dependency of `hadoop-common`:
```
[INFO] -------------------< org.apache.pinot:pinot-hadoop >--------------------
[INFO] Building Pinot Hadoop 0.6.0-SNAPSHOT [35/46]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ pinot-hadoop ---
[INFO] org.apache.pinot:pinot-hadoop:jar:0.6.0-SNAPSHOT
[INFO] \- org.apache.hadoop:hadoop-client:jar:2.7.0:provided
[INFO] \- org.apache.hadoop:hadoop-common:jar:2.7.0:provided (scope managed from compile)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6088: Put Hadoop dependencies down to pinot-orc, pinot-parquet modules
Posted by GitBox <gi...@apache.org>.
jackjlli commented on a change in pull request #6088:
URL: https://github.com/apache/incubator-pinot/pull/6088#discussion_r502024417
##########
File path: pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/pom.xml
##########
@@ -119,6 +119,10 @@
<groupId>org.apache.pinot</groupId>
<artifactId>pinot-core</artifactId>
</exclusion>
+ <exclusion>
Review comment:
We are not gonna exclude all the `hadoop-common` from `pinot-hadoop`. `hadoop-client` keeps the dependency of `hadoop-common`:
```
[INFO] -------------------< org.apache.pinot:pinot-hadoop >--------------------
[INFO] Building Pinot Hadoop 0.6.0-SNAPSHOT [35/46]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ pinot-hadoop ---
[INFO] org.apache.pinot:pinot-hadoop:jar:0.6.0-SNAPSHOT
[INFO] \- org.apache.hadoop:hadoop-client:jar:2.7.0:provided
[INFO] \- org.apache.hadoop:hadoop-common:jar:2.7.0:provided (scope managed from compile)
```
##########
File path: pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/pom.xml
##########
@@ -119,6 +119,10 @@
<groupId>org.apache.pinot</groupId>
<artifactId>pinot-core</artifactId>
</exclusion>
+ <exclusion>
Review comment:
We are not gonna exclude all the `hadoop-common` from `pinot-hadoop`. `hadoop-client` still keeps the dependency of `hadoop-common`:
```
[INFO] -------------------< org.apache.pinot:pinot-hadoop >--------------------
[INFO] Building Pinot Hadoop 0.6.0-SNAPSHOT [35/46]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ pinot-hadoop ---
[INFO] org.apache.pinot:pinot-hadoop:jar:0.6.0-SNAPSHOT
[INFO] \- org.apache.hadoop:hadoop-client:jar:2.7.0:provided
[INFO] \- org.apache.hadoop:hadoop-common:jar:2.7.0:provided (scope managed from compile)
```
##########
File path: pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/pom.xml
##########
@@ -119,6 +119,10 @@
<groupId>org.apache.pinot</groupId>
<artifactId>pinot-core</artifactId>
</exclusion>
+ <exclusion>
Review comment:
We are not gonna exclude all the `hadoop-common` from `pinot-hadoop`. `hadoop-client` still keeps the dependency of `hadoop-common`:
```
[INFO] -------------------< org.apache.pinot:pinot-hadoop >--------------------
[INFO] Building Pinot Hadoop 0.6.0-SNAPSHOT [35/46]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ pinot-hadoop ---
[INFO] org.apache.pinot:pinot-hadoop:jar:0.6.0-SNAPSHOT
[INFO] \- org.apache.hadoop:hadoop-client:jar:2.7.0:provided
[INFO] \- org.apache.hadoop:hadoop-common:jar:2.7.0:provided (scope managed from compile)
```
Plus, it'd always be good to exclude duplicate dependencies and keep only 1 in the pom file to avoiding introducing multiple versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6088: Put Hadoop dependencies down to pinot-orc, pinot-parquet modules
Posted by GitBox <gi...@apache.org>.
mayankshriv commented on a change in pull request #6088:
URL: https://github.com/apache/incubator-pinot/pull/6088#discussion_r501853474
##########
File path: pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/pom.xml
##########
@@ -119,6 +119,10 @@
<groupId>org.apache.pinot</groupId>
<artifactId>pinot-core</artifactId>
</exclusion>
+ <exclusion>
Review comment:
Why do we need to exclude `hadoop-common` from `pinot-hadoop`? Seems a legit dependency?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6088: Put Hadoop dependencies down to pinot-orc, pinot-parquet modules
Posted by GitBox <gi...@apache.org>.
mayankshriv commented on a change in pull request #6088:
URL: https://github.com/apache/incubator-pinot/pull/6088#discussion_r501853474
##########
File path: pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/pom.xml
##########
@@ -119,6 +119,10 @@
<groupId>org.apache.pinot</groupId>
<artifactId>pinot-core</artifactId>
</exclusion>
+ <exclusion>
Review comment:
Why do we need to exclude `hadoop-common` from `pinot-hadoop`? Seems a legit dependency?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6088: Put Hadoop dependencies down to pinot-orc, pinot-parquet modules
Posted by GitBox <gi...@apache.org>.
jackjlli commented on a change in pull request #6088:
URL: https://github.com/apache/incubator-pinot/pull/6088#discussion_r502024417
##########
File path: pinot-plugins/pinot-batch-ingestion/v0_deprecated/pinot-hadoop/pom.xml
##########
@@ -119,6 +119,10 @@
<groupId>org.apache.pinot</groupId>
<artifactId>pinot-core</artifactId>
</exclusion>
+ <exclusion>
Review comment:
We are not gonna exclude all the `hadoop-common` from `pinot-hadoop`. `hadoop-client` still keeps the dependency of `hadoop-common`:
```
[INFO] -------------------< org.apache.pinot:pinot-hadoop >--------------------
[INFO] Building Pinot Hadoop 0.6.0-SNAPSHOT [35/46]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ pinot-hadoop ---
[INFO] org.apache.pinot:pinot-hadoop:jar:0.6.0-SNAPSHOT
[INFO] \- org.apache.hadoop:hadoop-client:jar:2.7.0:provided
[INFO] \- org.apache.hadoop:hadoop-common:jar:2.7.0:provided (scope managed from compile)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org