You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/03/27 03:31:30 UTC

[GitHub] [pulsar] zhanghaou opened a new pull request #6621: Fix message id compare

zhanghaou opened a new pull request #6621: Fix message id compare
URL: https://github.com/apache/pulsar/pull/6621
 
 
   Master Issue: #6433
   
   Motivation
   Fix the bug of compare between MessageId and BatchMessageId, keep the symmetry of compareTo method.
   
   Modifications
   In the mothod of compareTo in BatchMessageId class, when compare to non-batched messageId and other properties is equal，if batchIndex >-1, then return 1, so in MessageId class, add the same logic, and if batchIndex >-1, then return -1.
   
   Verifying this change
   Unit tests added.
   
   Does this pull request potentially affect one of the following parts:
   If yes was chosen, please highlight the changes
   
   Dependencies (does it add or upgrade a dependency): (no)
   The public API: (no)
   The schema: (no)
   The default values of configurations: (no)
   The wire protocol: (no)
   The rest endpoints: (no)
   The admin cli options: (no)
   Anything that affects deployment: (no)
   Documentation
   Does this pull request introduce a new feature? (no)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie merged pull request #6621: [Issue 6433][Pulsar-client]Fix message id compare between MessageId and BatchMessageId

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #6621: [Issue 6433][Pulsar-client]Fix message id compare between MessageId and BatchMessageId
URL: https://github.com/apache/pulsar/pull/6621
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on issue #6621: [Issue 6433][Pulsar-client]Fix message id compare between MessageId and BatchMessageId

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on issue #6621: [Issue 6433][Pulsar-client]Fix message id compare between MessageId and BatchMessageId
URL: https://github.com/apache/pulsar/pull/6621#issuecomment-604908939
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services