Solr CHANGES.txt 8.8 adjustment proposal

[David Smiley <ds...@apache.org>]

I'm looking at the CHANGES.txt file to see what's coming in 8.8.  Under the
Improvements section I see multiple things that strike me as optimization
-- a *type of* improvement, sure, but we have a dedicated Optimizations
section in the CHANGES.txt.  Here are the ones that seem like candidates to
move:

* SOLR-14942: Reduce leader election time on node shutdown by removing
election nodes before closing cores.
  (Cao Manh Dat, Mike Drob, hossman, shalin)

* SOLR-14827: Refactor schema loading to not use XPath (noble)

Also, I see an "Upgrade Notes" section, that Hossman added (CC'ed), but I
think as a community we agreed to omit such things from our CHANGES.txt and
instead rely on solr-upgrade-notes.adoc (referenced at the *very* top of
the file).  For this particular upgrade note concerning identifying Solr
Home for internals & plugins, I think it's too internal to even mention at
all.

Ishan:  as the RM, maybe you can move/remove these if you agree.

~ David Smiley
Apache Lucene/Solr Search Developer
http://www.linkedin.com/in/davidwsmiley

Re: Solr CHANGES.txt 8.8 adjustment proposal

[David Smiley <ds...@apache.org>]

Modifying changes2html.pl would be like going from SHOULD NOT to a MUST
NOT.  I'd prefer we have the flexibility to add a header when we feel it's
appropriate.

~ David Smiley
Apache Lucene/Solr Search Developer
http://www.linkedin.com/in/davidwsmiley


On Thu, Jan 14, 2021 at 12:25 PM Chris Hostetter <ho...@fucit.org>
wrote:

>
> : Also, I see an "Upgrade Notes" section, that Hossman added (CC'ed), but I
> : think as a community we agreed to omit such things from our CHANGES.txt
> and
> : instead rely on solr-upgrade-notes.adoc (referenced at the *very* top of
>
> I don't remember that decision being made -- but ok, fair enough...
>
> If the plan moving forward is that there should be a pre-determined set of
> headers, and that devs shouldn't be adding headings like "Upgrade Notes"
> as needed anymore, then I would like to suggest someone
> should probably make 'changes2html.pl' (or some othe tool run on
> 'check') fail if an unexpected header is added?
>
>
>
> -Hoss
> http://www.lucidworks.com/
>

Re: Solr CHANGES.txt 8.8 adjustment proposal

[Chris Hostetter <ho...@fucit.org>]

: Also, I see an "Upgrade Notes" section, that Hossman added (CC'ed), but I
: think as a community we agreed to omit such things from our CHANGES.txt and
: instead rely on solr-upgrade-notes.adoc (referenced at the *very* top of

I don't remember that decision being made -- but ok, fair enough...

If the plan moving forward is that there should be a pre-determined set of 
headers, and that devs shouldn't be adding headings like "Upgrade Notes" 
as needed anymore, then I would like to suggest someone 
should probably make 'changes2html.pl' (or some othe tool run on 
'check') fail if an unexpected header is added?



-Hoss
http://www.lucidworks.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org