You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/26 16:01:52 UTC
[GitHub] [arrow-datafusion] Ted-Jiang opened a new pull request #2098: [Ballista] Support Union in ballista.
Ted-Jiang opened a new pull request #2098:
URL: https://github.com/apache/arrow-datafusion/pull/2098
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #2032 .
# Rationale for this change
Now use `cargo run --bin datafusion-cli --features ballista -- --host localhost --port 50050`
```
❯ SELECT 1 as NUMBER union SELECT 1 as NUMBER;
+--------+
| number |
+--------+
| 1 |
+--------+
1 row in set. Query took 1.085 seconds.
❯ SELECT 1 as NUMBER union all SELECT 1 as NUMBER;
+--------+
| number |
+--------+
| 1 |
| 1 |
+--------+
2 rows in set. Query took 0.225 seconds.
```
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Ted-Jiang commented on a change in pull request #2098: [Ballista] Support Union in ballista.
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on a change in pull request #2098:
URL: https://github.com/apache/arrow-datafusion/pull/2098#discussion_r835851916
##########
File path: datafusion/src/physical_plan/union.rs
##########
@@ -43,7 +43,7 @@ use async_trait::async_trait;
#[derive(Debug)]
pub struct UnionExec {
/// Input execution plan
- inputs: Vec<Arc<dyn ExecutionPlan>>,
+ pub inputs: Vec<Arc<dyn ExecutionPlan>>,
Review comment:
Thanks ❤️ fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] houqp commented on a change in pull request #2098: [Ballista] Support Union in ballista.
Posted by GitBox <gi...@apache.org>.
houqp commented on a change in pull request #2098:
URL: https://github.com/apache/arrow-datafusion/pull/2098#discussion_r835826477
##########
File path: datafusion/src/physical_plan/union.rs
##########
@@ -43,7 +43,7 @@ use async_trait::async_trait;
#[derive(Debug)]
pub struct UnionExec {
/// Input execution plan
- inputs: Vec<Arc<dyn ExecutionPlan>>,
+ pub inputs: Vec<Arc<dyn ExecutionPlan>>,
Review comment:
better keep it consistent across different physical plans, other plans keep this field private and choose to expose it through an `input` method instead, see the limit plan for an example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #2098: [Ballista] Support Union in ballista.
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #2098:
URL: https://github.com/apache/arrow-datafusion/pull/2098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org