[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #117: Pick Largest Bin at Task Planning

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #117: Pick Largest Bin at Task Planning
URL: https://github.com/apache/incubator-iceberg/pull/117#discussion_r267022099
 
 

 ##########
 File path: core/src/main/java/com/netflix/iceberg/util/BinPacking.java
 ##########
 @@ -78,13 +84,15 @@ public PackingIterable(Iterable<T> iterable, long targetWeight, int lookback,
     private final long targetWeight;
     private final int lookback;
     private final Function<T, Long> weightFunc;
+    private final boolean largestBinFirst;
 
     private PackingIterator(Iterator<T> items, long targetWeight, int lookback,
-                            Function<T, Long> weightFunc) {
+                            Function<T, Long> weightFunc, boolean largestBinFirst) {
 
 Review comment:
   This follows the conventions I was using for a while. I think it is fine in this PR and we will fix the style when we standardize on one format.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org