You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficserver.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2013/04/01 20:29:16 UTC

[jira] [Commented] (TS-1772) Remove multiple TS_INLINE defines

    [ https://issues.apache.org/jira/browse/TS-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619015#comment-13619015 ] 

ASF subversion and git services commented on TS-1772:
-----------------------------------------------------

Commit 7ca19476f5e0b52f9d65cb11df051c045b832542 in branch refs/heads/master from James Peach <jp...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=7ca1947 ]

TS-1772: Remove multiple TS_INLINE defines

It took me a couple of tries to understand what the Inline.cc files
were for, but it's actually not necessary for TS_INLINE to be defined
in many different places. All we need to do to get correct inlining
is define an extern version, and make an inline version available
in a header. Forward declarations should be extern, not TS_INLINE.

                
> Remove multiple TS_INLINE defines
> ---------------------------------
>
>                 Key: TS-1772
>                 URL: https://issues.apache.org/jira/browse/TS-1772
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Build
>            Reporter: James Peach
>            Assignee: James Peach
>             Fix For: 3.3.2
>
>
> The use of Inline.cc files was probably related to old compilers not inlining things correctly, or possibly some code bloat issues. Right now they are just confusing and cluttering up the build system; let's remove them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira