You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openmeetings.apache.org by so...@apache.org on 2020/04/30 15:44:57 UTC
[openmeetings] branch master updated: [OPENMEETINGS-2301] minor JS
error is fixed
This is an automated email from the ASF dual-hosted git repository.
solomax pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openmeetings.git
The following commit(s) were added to refs/heads/master by this push:
new fd27975 [OPENMEETINGS-2301] minor JS error is fixed
fd27975 is described below
commit fd279752b6d9d9a0444c2f37145b876754da6477
Author: Maxim Solodovnik <so...@gmail.com>
AuthorDate: Thu Apr 30 22:44:38 2020 +0700
[OPENMEETINGS-2301] minor JS error is fixed
---
.../org/apache/openmeetings/web/room/raw-video-util.js | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-video-util.js b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-video-util.js
index f041211..7202f81 100644
--- a/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-video-util.js
+++ b/openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-video-util.js
@@ -316,6 +316,7 @@ var Volume = (function() {
function _create(_video) {
video = _video;
+ _destroy();
const uid = video.stream().uid
, volId = 'volume-' + uid;
vol = OmUtil.tmpl('#volume-control-stub', volId)
@@ -397,6 +398,12 @@ var Volume = (function() {
_handle(lastVolume);
}
}
+ function _destroy() {
+ if (vol) {
+ vol.remove();
+ vol = null;
+ }
+ }
return {
create: _create
@@ -405,11 +412,6 @@ var Volume = (function() {
, muted: function() {
return muted;
}
- , destroy: function() {
- if (vol) {
- vol.remove();
- vol = null;
- }
- }
+ , destroy: _destroy
};
});