[GitHub] nifi issue #1376: NIFI-3268 Add AUTO_INCREMENT column in GenerateTableFetch ...

[ijokarumawak <gi...@git.apache.org>]

Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/1376
  
    Hi @qfdk , excuse me for not providing further review comments. Today, I wanted to test this updated PR but unfortunately it is conflicted. Would you rebase it with the latest master, address merge conflict and squash commits into one? Please let us know when it gets ready to resume review.
    
    It may not be ideal, but I think it will take time to get this PR fully reviewed with various DBMS to see if it works as expected and how it can improve performance. On the other hand, the NiFi community is [discussing about releasing 1.2.0](http://apache-nifi-developer-list.39713.n7.nabble.com/Closing-in-on-a-NiFi-1-2-0-release-td14907.html). To make this effort along with the release cycles, can we remove 1.2.0 as Fix Version from JIRA [NIFI-3268](https://issues.apache.org/jira/browse/NIFI-3268)? The Fix Version is used to track which version the issue is fixed, and should be empty until it's resolved.
    
    Thanks for your contribution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---