You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Philip Martin <ph...@codematters.co.uk> on 2004/04/23 19:13:04 UTC
Re: svn commit: r9468 - trunk/subversion/libsvn_fs_fs
ghudson@tigris.org writes:
> Author: ghudson
> Date: Thu Apr 22 23:36:33 2004
> New Revision: 9468
>
> Modified: trunk/subversion/libsvn_fs_fs/make-revs.c
> ==============================================================================
> --- trunk/subversion/libsvn_fs_fs/make-revs.c (original)
> +++ trunk/subversion/libsvn_fs_fs/make-revs.c Thu Apr 22 23:36:33 2004
> @@ -569,7 +569,7 @@
> static const char *
> txn_revstr(struct parse_baton *pb, svn_revnum_t rev, apr_pool_t *pool)
> {
> - return (rev == pb->current_rev) ? "this"
> + return (rev == pb->current_rev) ? "-1"
Perhaps
return (rev == pb->current_rev) ? APR_STRINGIFY(SVN_INVALID_REVNUM)
or do you deliberately allowing it to be different?
> : apr_psprintf(pool, "%" SVN_REVNUM_T_FMT, rev);
> }
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r9468 - trunk/subversion/libsvn_fs_fs
Posted by Greg Hudson <gh...@MIT.EDU>.
On Fri, 2004-04-23 at 15:13, Philip Martin wrote:
> > - return (rev == pb->current_rev) ? "this"
> > + return (rev == pb->current_rev) ? "-1"
>
> Perhaps
>
> return (rev == pb->current_rev) ? APR_STRINGIFY(SVN_INVALID_REVNUM)
>
> or do you deliberately allowing it to be different?
make-revs.c is temporary code; cutting corners like that isn't a
problem.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org