[GitHub] [incubator-kyuubi] yanghua commented on a change in pull request #1256: [KYUUBI #1252] Move KyuubiConf#toSparkPrefixedConf out of kyuubi-common module

[GitBox <gi...@apache.org>]

yanghua commented on a change in pull request #1256:
URL: https://github.com/apache/incubator-kyuubi/pull/1256#discussion_r731554746



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala
##########
@@ -123,7 +124,7 @@ class SparkProcessBuilder(
     buffer += executable
     buffer += CLASS
     buffer += mainClass
-    conf.toSparkPrefixedConf.foreach { case (k, v) =>
+    getSparkPrefixedConf.foreach { case (k, v) =>

Review comment:
       > Why the method name changed? We should avoid using getXXX because it is more like the property accessor
   
   The reason is that we move it and inline it into `SparkProcessBuilder`, so removed the **caller** and subject `conf`. `conf.toSparkPrefixedConf` sounds good. But `SparkProcessBuilder#toSparkPrefixedConf` seems weird compared with `SparkProcessBuilder#getSparkPrefixedConf` or `SparkProcessBuilder#covertConfWithSparkPrefix`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org