You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2014/09/27 01:04:16 UTC

Re: Review Request 26108: Admin View: deploying status should update automatically

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26108/
-----------------------------------------------------------

(Updated Sept. 26, 2014, 11:04 p.m.)

Review request for Ambari, Jaimin Jetly and Yusaku Sako.

Bugs: AMBARI-7527
https://issues.apache.org/jira/browse/AMBARI-7527

Repository: ambari

Description
-------

When a view is being deployed, its status in Ambari Admin shows as "Deploying...", but when the background task finishes, the status does not change to completed.

Diffs
-----

ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsListCtrl.js ed97a19
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/View.js e30dcf3

Diff: https://reviews.apache.org/r/26108/diff/

Testing
-------

Verified that it works by running the following steps.

Copy changesto VM:
1. cd /var/lib/ambari-server/resources/views/
2. cp /vagrant/ambari/ambari-admin/target/ambari-admin-1.3.0-SNAPSHOT.jar /var/lib/ambari-server/resources/views/ambari-admin-1.7.0.190.jar
3. rm -rf work/ADMIN_VIEW{1.0.0}/
4. ambari-server restart

Cause View to be registered in background task:
1. rm -rf work/ADMIN_VIEW{1.0.0}/
2. ambari-server restart
3. open two browser tabs to the Admin Views page, and verify that both initially show "Deploying...", and eventually complete with the View version without having to refresh the browser

Thanks,

Alejandro Fernandez

Re: Review Request 26108: Admin View: deploying status should update automatically

Posted by Yusaku Sako <yu...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26108/#review54912
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Sept. 29, 2014, 11 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26108/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2014, 11 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
> 
> 
> Bugs: AMBARI-7527
>     https://issues.apache.org/jira/browse/AMBARI-7527
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When a view is being deployed, its status in Ambari Admin shows as "Deploying...", but when the background task finishes, the status does not change to completed.
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsListCtrl.js ed97a19 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/View.js e30dcf3 
> 
> Diff: https://reviews.apache.org/r/26108/diff/
> 
> 
> Testing
> -------
> 
> Verified that it works by running the following steps.
> 
> Copy changesto VM:
> 1. cd /var/lib/ambari-server/resources/views/
> 2. cp /vagrant/ambari/ambari-admin/target/ambari-admin-1.3.0-SNAPSHOT.jar /var/lib/ambari-server/resources/views/ambari-admin-1.7.0.190.jar
> 3. rm -rf work/ADMIN_VIEW{1.0.0}/
> 4. ambari-server restart
> 
> Cause View to be registered in background task:
> 1. rm -rf work/SLIDER_VIEW{1.0.0}/
> 2. ambari-server restart
> 3. open two browser tabs to the Admin Views page, and verify that both initially show "Deploying...", and eventually complete with the View version without having to refresh the browser
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 26108: Admin View: deploying status should update automatically

Posted by Alejandro Fernandez <af...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26108/
-----------------------------------------------------------

(Updated Sept. 29, 2014, 11 p.m.)


Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Bugs: AMBARI-7527
    https://issues.apache.org/jira/browse/AMBARI-7527


Repository: ambari


Description
-------

When a view is being deployed, its status in Ambari Admin shows as "Deploying...", but when the background task finishes, the status does not change to completed.


Diffs
-----

  ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsListCtrl.js ed97a19 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/View.js e30dcf3 

Diff: https://reviews.apache.org/r/26108/diff/


Testing (updated)
-------

Verified that it works by running the following steps.

Copy changesto VM:
1. cd /var/lib/ambari-server/resources/views/
2. cp /vagrant/ambari/ambari-admin/target/ambari-admin-1.3.0-SNAPSHOT.jar /var/lib/ambari-server/resources/views/ambari-admin-1.7.0.190.jar
3. rm -rf work/ADMIN_VIEW{1.0.0}/
4. ambari-server restart

Cause View to be registered in background task:
1. rm -rf work/SLIDER_VIEW{1.0.0}/
2. ambari-server restart
3. open two browser tabs to the Admin Views page, and verify that both initially show "Deploying...", and eventually complete with the View version without having to refresh the browser


Thanks,

Alejandro Fernandez

Re: Review Request 26108: Admin View: deploying status should update automatically

Posted by Yusaku Sako <yu...@hortonworks.com>.


> On Sept. 29, 2014, 10:55 p.m., Yusaku Sako wrote:
> > In the test procedure you mentioned, do you mean you deleted a view other than Ambari Admin view?
> > Ambari Admin view does not show up in the list of Views.
> 
> Alejandro Fernandez wrote:
>     Good catch, yes, I deleted SLIDER view since it takes longer to register.

because it is a system view, so I don't think we can use that for verification.


- Yusaku


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26108/#review54906
-----------------------------------------------------------


On Sept. 29, 2014, 11 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26108/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2014, 11 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
> 
> 
> Bugs: AMBARI-7527
>     https://issues.apache.org/jira/browse/AMBARI-7527
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When a view is being deployed, its status in Ambari Admin shows as "Deploying...", but when the background task finishes, the status does not change to completed.
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsListCtrl.js ed97a19 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/View.js e30dcf3 
> 
> Diff: https://reviews.apache.org/r/26108/diff/
> 
> 
> Testing
> -------
> 
> Verified that it works by running the following steps.
> 
> Copy changesto VM:
> 1. cd /var/lib/ambari-server/resources/views/
> 2. cp /vagrant/ambari/ambari-admin/target/ambari-admin-1.3.0-SNAPSHOT.jar /var/lib/ambari-server/resources/views/ambari-admin-1.7.0.190.jar
> 3. rm -rf work/ADMIN_VIEW{1.0.0}/
> 4. ambari-server restart
> 
> Cause View to be registered in background task:
> 1. rm -rf work/SLIDER_VIEW{1.0.0}/
> 2. ambari-server restart
> 3. open two browser tabs to the Admin Views page, and verify that both initially show "Deploying...", and eventually complete with the View version without having to refresh the browser
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 26108: Admin View: deploying status should update automatically

Posted by Alejandro Fernandez <af...@hortonworks.com>.


> On Sept. 29, 2014, 10:55 p.m., Yusaku Sako wrote:
> > In the test procedure you mentioned, do you mean you deleted a view other than Ambari Admin view?
> > Ambari Admin view does not show up in the list of Views.

Good catch, yes, I deleted SLIDER view since it takes longer to register.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26108/#review54906
-----------------------------------------------------------


On Sept. 29, 2014, 11 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26108/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2014, 11 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
> 
> 
> Bugs: AMBARI-7527
>     https://issues.apache.org/jira/browse/AMBARI-7527
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When a view is being deployed, its status in Ambari Admin shows as "Deploying...", but when the background task finishes, the status does not change to completed.
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsListCtrl.js ed97a19 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/View.js e30dcf3 
> 
> Diff: https://reviews.apache.org/r/26108/diff/
> 
> 
> Testing
> -------
> 
> Verified that it works by running the following steps.
> 
> Copy changesto VM:
> 1. cd /var/lib/ambari-server/resources/views/
> 2. cp /vagrant/ambari/ambari-admin/target/ambari-admin-1.3.0-SNAPSHOT.jar /var/lib/ambari-server/resources/views/ambari-admin-1.7.0.190.jar
> 3. rm -rf work/ADMIN_VIEW{1.0.0}/
> 4. ambari-server restart
> 
> Cause View to be registered in background task:
> 1. rm -rf work/SLIDER_VIEW{1.0.0}/
> 2. ambari-server restart
> 3. open two browser tabs to the Admin Views page, and verify that both initially show "Deploying...", and eventually complete with the View version without having to refresh the browser
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 26108: Admin View: deploying status should update automatically

Posted by Yusaku Sako <yu...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26108/#review54906
-----------------------------------------------------------


In the test procedure you mentioned, do you mean you deleted a view other than Ambari Admin view?
Ambari Admin view does not show up in the list of Views.

- Yusaku Sako


On Sept. 26, 2014, 11:04 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26108/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2014, 11:04 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
> 
> 
> Bugs: AMBARI-7527
>     https://issues.apache.org/jira/browse/AMBARI-7527
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> When a view is being deployed, its status in Ambari Admin shows as "Deploying...", but when the background task finishes, the status does not change to completed.
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsListCtrl.js ed97a19 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/View.js e30dcf3 
> 
> Diff: https://reviews.apache.org/r/26108/diff/
> 
> 
> Testing
> -------
> 
> Verified that it works by running the following steps.
> 
> Copy changesto VM:
> 1. cd /var/lib/ambari-server/resources/views/
> 2. cp /vagrant/ambari/ambari-admin/target/ambari-admin-1.3.0-SNAPSHOT.jar /var/lib/ambari-server/resources/views/ambari-admin-1.7.0.190.jar
> 3. rm -rf work/ADMIN_VIEW{1.0.0}/
> 4. ambari-server restart
> 
> Cause View to be registered in background task:
> 1. rm -rf work/ADMIN_VIEW{1.0.0}/
> 2. ambari-server restart
> 3. open two browser tabs to the Admin Views page, and verify that both initially show "Deploying...", and eventually complete with the View version without having to refresh the browser
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>