You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Julian Reschke (Jira)" <ji...@apache.org> on 2019/10/30 14:26:00 UTC
[jira] [Comment Edited] (OAK-8052) PersistentCache: failure during
construction may lead to resource leak
[ https://issues.apache.org/jira/browse/OAK-8052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773955#comment-16773955 ]
Julian Reschke edited comment on OAK-8052 at 10/30/19 2:25 PM:
---------------------------------------------------------------
trunk: (1.12.0) [r1854034|http://svn.apache.org/r1854034]
1.10: (1.10.1) [r1854070|http://svn.apache.org/r1854070]
1.8: (1.8.13) [r1855881|http://svn.apache.org/r1855881]
1.6: (1.6.18) [r1862888|http://svn.apache.org/r1862888]
1.4: [r1869174|http://svn.apache.org/r1869174]
was (Author: reschke):
trunk: (1.12.0) [r1854034|http://svn.apache.org/r1854034]
1.10: (1.10.1) [r1854070|http://svn.apache.org/r1854070]
1.8: (1.8.13) [r1855881|http://svn.apache.org/r1855881]
1.6: [r1862888|http://svn.apache.org/r1862888]
> PersistentCache: failure during construction may lead to resource leak
> ----------------------------------------------------------------------
>
> Key: OAK-8052
> URL: https://issues.apache.org/jira/browse/OAK-8052
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: documentmk
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Fix For: 1.12.0, 1.4.25, 1.10.1, 1.8.13, 1.6.18
>
> Attachments: OAK-8052.diff
>
>
> In the constructor:
> {noformat}
> readGeneration = generations.size() > 1 ? generations.first() : -1;
> writeGeneration = generations.size() > 0 ? generations.last() : 0;
> if (readGeneration >= 0) {
> readStore = createMapFactory(readGeneration, true);
> }
> writeStore = createMapFactory(writeGeneration, false);
> initBroadcast(broadcast);
> {noformat}
> ...so if {{createMapFactory}} fails for {{writeStore}}, {{readStore}} will not be closed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)