You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/09/01 14:11:43 UTC

[GitHub] [couchdb] bessbd opened a new pull request #3120: Fix stale=false for views

bessbd opened a new pull request #3120:
URL: https://github.com/apache/couchdb/pull/3120


   ## Overview
   
   The docs mention an option of "false" for "stale" which is currently not supported and is rejected by validation.
   
   This commit fixes the problem described above.
   
   ## Testing recommendations
   
   `make eunit apps=couch_mrview suites=couch_mrview_http`
   
   ## Related Issues or Pull Requests
   
   N/A
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [x] Changes are covered by tests
   - [x] Any new configurable parameters are documented in `rel/overlay/etc/default.ini` -- not applicable
   - [x] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation -- this PR makes behavior match behavior described in https://docs.couchdb.org/en/stable/api/ddoc/views.html#api-ddoc-view


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] bessbd commented on pull request #3120: Fix stale=false for views

Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #3120:
URL: https://github.com/apache/couchdb/pull/3120#issuecomment-684927429


   Thank you for the feedback, @eiri and @wohali . I'll close this PR and open a new one for docs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] bessbd closed pull request #3120: Fix stale=false for views

Posted by GitBox <gi...@apache.org>.
bessbd closed pull request #3120:
URL: https://github.com/apache/couchdb/pull/3120


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] wohali commented on pull request #3120: Fix stale=false for views

Posted by GitBox <gi...@apache.org>.
wohali commented on pull request #3120:
URL: https://github.com/apache/couchdb/pull/3120#issuecomment-684923839


   I agree with @eiri here. The `stale` parameter was supposed to be deprecated in 3.x, but we gave it a reprieve until 4.0 (and maybe beyond that).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org