You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/14 19:00:59 UTC

[GitHub] [airflow] yqian1991 opened a new pull request #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules

yqian1991 opened a new pull request #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules
URL: https://github.com/apache/airflow/pull/7167
 
 
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] yqian1991 commented on issue #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules

Posted by GitBox <gi...@apache.org>.
yqian1991 commented on issue #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules
URL: https://github.com/apache/airflow/pull/7167#issuecomment-576828383
 
 
   Closing this, seems like

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] yqian1991 commented on a change in pull request #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules

Posted by GitBox <gi...@apache.org>.
yqian1991 commented on a change in pull request #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules
URL: https://github.com/apache/airflow/pull/7167#discussion_r366531206
 
 

 ##########
 File path: airflow/contrib/sensors/celery_queue_sensor.py
 ##########
 @@ -16,74 +16,14 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+"""This module is deprecated. Please use `airflow.providers.apache.cassandra.hooks.cassandra`."""
 
 Review comment:
   stupid mistake, will fix it soon

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] yqian1991 edited a comment on issue #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules

Posted by GitBox <gi...@apache.org>.
yqian1991 edited a comment on issue #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules
URL: https://github.com/apache/airflow/pull/7167#issuecomment-576828383
 
 
   Closing this, seems like a duplicate work of another pr

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules
URL: https://github.com/apache/airflow/pull/7167#issuecomment-574911784
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=h1) Report
   > Merging [#7167](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/417feda5eba6cc63c01a9a04a7b48bc24f63a3d1?src=pr&el=desc) will **decrease** coverage by `0.62%`.
   > The diff coverage is `71.87%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7167/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7167      +/-   ##
   ==========================================
   - Coverage   85.25%   84.62%   -0.63%     
   ==========================================
     Files         723      724       +1     
     Lines       39543    39547       +4     
   ==========================================
   - Hits        33711    33467     -244     
   - Misses       5832     6080     +248
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/contrib/sensors/celery\_queue\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvY2VsZXJ5X3F1ZXVlX3NlbnNvci5weQ==) | `0% <0%> (-82.15%)` | :arrow_down: |
   | [airflow/providers/celery/sensors/celery.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY2VsZXJ5L3NlbnNvcnMvY2VsZXJ5LnB5) | `82.14% <82.14%> (ø)` | |
   | [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.31% <0%> (-20.49%)` | :arrow_down: |
   | ... and [8 more](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=footer). Last update [417feda...0a878d7](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] yqian1991 edited a comment on issue #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules

Posted by GitBox <gi...@apache.org>.
yqian1991 edited a comment on issue #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules
URL: https://github.com/apache/airflow/pull/7167#issuecomment-576828383
 
 
   Closing this, seems like somebody changed this in a later pr

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules
URL: https://github.com/apache/airflow/pull/7167#issuecomment-574911784
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=h1) Report
   > Merging [#7167](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/59c8a826b8d5d365db68e800cea3de59256530c9?src=pr&el=desc) will **increase** coverage by `0.59%`.
   > The diff coverage is `71.87%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7167/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7167      +/-   ##
   ==========================================
   + Coverage   84.91%   85.51%   +0.59%     
   ==========================================
     Files         723      759      +36     
     Lines       39546    39936     +390     
   ==========================================
   + Hits        33581    34150     +569     
   + Misses       5965     5786     -179
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/contrib/sensors/celery\_queue\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvY2VsZXJ5X3F1ZXVlX3NlbnNvci5weQ==) | `0% <0%> (-82.15%)` | :arrow_down: |
   | [airflow/providers/celery/sensors/celery.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY2VsZXJ5L3NlbnNvcnMvY2VsZXJ5LnB5) | `82.14% <82.14%> (ø)` | |
   | [...rflow/contrib/sensors/sagemaker\_training\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvc2FnZW1ha2VyX3RyYWluaW5nX3NlbnNvci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/api/client/local\_client.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY2xpZW50L2xvY2FsX2NsaWVudC5weQ==) | `92% <0%> (-8%)` | :arrow_down: |
   | [airflow/api/client/api\_client.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY2xpZW50L2FwaV9jbGllbnQucHk=) | `63.15% <0%> (-1.55%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `97.64% <0%> (-1.15%)` | :arrow_down: |
   | [airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=) | `88.37% <0%> (-0.92%)` | :arrow_down: |
   | [airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5) | `95.13% <0%> (-0.67%)` | :arrow_down: |
   | [airflow/cli/commands/dag\_command.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGFnX2NvbW1hbmQucHk=) | `85.9% <0%> (-0.31%)` | :arrow_down: |
   | [airflow/contrib/sensors/emr\_base\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZW1yX2Jhc2Vfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
   | ... and [94 more](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=footer). Last update [59c8a82...b94c003](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules
URL: https://github.com/apache/airflow/pull/7167#issuecomment-574911784
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=h1) Report
   > Merging [#7167](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/59c8a826b8d5d365db68e800cea3de59256530c9?src=pr&el=desc) will **increase** coverage by `0.59%`.
   > The diff coverage is `71.87%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7167/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7167      +/-   ##
   ==========================================
   + Coverage   84.91%   85.51%   +0.59%     
   ==========================================
     Files         723      759      +36     
     Lines       39546    39936     +390     
   ==========================================
   + Hits        33581    34150     +569     
   + Misses       5965     5786     -179
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/contrib/sensors/celery\_queue\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvY2VsZXJ5X3F1ZXVlX3NlbnNvci5weQ==) | `0% <0%> (-82.15%)` | :arrow_down: |
   | [airflow/providers/celery/sensors/celery.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY2VsZXJ5L3NlbnNvcnMvY2VsZXJ5LnB5) | `82.14% <82.14%> (ø)` | |
   | [...rflow/contrib/sensors/sagemaker\_training\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvc2FnZW1ha2VyX3RyYWluaW5nX3NlbnNvci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/api/client/local\_client.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY2xpZW50L2xvY2FsX2NsaWVudC5weQ==) | `92% <0%> (-8%)` | :arrow_down: |
   | [airflow/api/client/api\_client.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY2xpZW50L2FwaV9jbGllbnQucHk=) | `63.15% <0%> (-1.55%)` | :arrow_down: |
   | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `97.64% <0%> (-1.15%)` | :arrow_down: |
   | [airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=) | `88.37% <0%> (-0.92%)` | :arrow_down: |
   | [airflow/operators/python\_operator.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcHl0aG9uX29wZXJhdG9yLnB5) | `95.13% <0%> (-0.67%)` | :arrow_down: |
   | [airflow/cli/commands/dag\_command.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvZGFnX2NvbW1hbmQucHk=) | `85.9% <0%> (-0.31%)` | :arrow_down: |
   | [airflow/contrib/sensors/emr\_base\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZW1yX2Jhc2Vfc2Vuc29yLnB5) | `100% <0%> (ø)` | :arrow_up: |
   | ... and [94 more](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=footer). Last update [59c8a82...b94c003](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules
URL: https://github.com/apache/airflow/pull/7167#discussion_r366525179
 
 

 ##########
 File path: airflow/contrib/sensors/celery_queue_sensor.py
 ##########
 @@ -16,74 +16,14 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+"""This module is deprecated. Please use `airflow.providers.apache.cassandra.hooks.cassandra`."""
 
 Review comment:
   ```suggestion
   """This module is deprecated. Please use `airflow.providers.celery.hooks.celery`."""
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] yqian1991 closed pull request #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules

Posted by GitBox <gi...@apache.org>.
yqian1991 closed pull request #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules
URL: https://github.com/apache/airflow/pull/7167
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7167: [AIRFLOW-5974] AIP-21 Change import paths for celery modules
URL: https://github.com/apache/airflow/pull/7167#issuecomment-574911784
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=h1) Report
   > Merging [#7167](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/417feda5eba6cc63c01a9a04a7b48bc24f63a3d1?src=pr&el=desc) will **increase** coverage by `0.11%`.
   > The diff coverage is `71.87%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7167/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7167      +/-   ##
   ==========================================
   + Coverage   85.25%   85.36%   +0.11%     
   ==========================================
     Files         723      724       +1     
     Lines       39543    39547       +4     
   ==========================================
   + Hits        33711    33761      +50     
   + Misses       5832     5786      -46
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/contrib/sensors/celery\_queue\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvY2VsZXJ5X3F1ZXVlX3NlbnNvci5weQ==) | `0% <0%> (-82.15%)` | :arrow_down: |
   | [airflow/providers/celery/sensors/celery.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY2VsZXJ5L3NlbnNvcnMvY2VsZXJ5LnB5) | `82.14% <82.14%> (ø)` | |
   | [airflow/jobs/scheduler\_job.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL3NjaGVkdWxlcl9qb2IucHk=) | `89.34% <0%> (+0.43%)` | :arrow_up: |
   | [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `91.73% <0%> (+1.65%)` | :arrow_up: |
   | [airflow/hooks/postgres\_hook.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wb3N0Z3Jlc19ob29rLnB5) | `94.36% <0%> (+16.9%)` | :arrow_up: |
   | [airflow/operators/postgres\_to\_gcs.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfdG9fZ2NzLnB5) | `85.29% <0%> (+32.35%)` | :arrow_up: |
   | [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/7167/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `100% <0%> (+100%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=footer). Last update [417feda...0a878d7](https://codecov.io/gh/apache/airflow/pull/7167?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services