You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "jacktengg (via GitHub)" <gi...@apache.org> on 2024/06/13 02:46:13 UTC
[PR] [refactor](spill) Delete not used code [doris]
jacktengg opened a new pull request, #36218:
URL: https://github.com/apache/doris/pull/36218
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](spill) Delete not used code [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36218:
URL: https://github.com/apache/doris/pull/36218#issuecomment-2164257036
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](spill) Delete not used code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36218:
URL: https://github.com/apache/doris/pull/36218#issuecomment-2164326598
TeamCity be ut coverage result:
Function Coverage: 36.36% (8966/24659)
Line Coverage: 27.88% (73293/262870)
Region Coverage: 27.33% (38031/139159)
Branch Coverage: 23.98% (19331/80612)
Coverage Report: http://coverage.selectdb-in.cc/coverage/418d878b75e3157c368d26e0b471e1d486150f42_418d878b75e3157c368d26e0b471e1d486150f42/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](spill) Delete not used code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36218:
URL: https://github.com/apache/doris/pull/36218#issuecomment-2164320764
<details>
<summary>TPC-H: <b>Total hot run time: 40604 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 418d878b75e3157c368d26e0b471e1d486150f42, data reload: false
------ Round 1 ----------------------------------
q1 17627 4483 4315 4315
q2 2041 189 205 189
q3 10447 1102 1101 1101
q4 10193 790 810 790
q5 7472 2701 2600 2600
q6 227 138 140 138
q7 964 606 590 590
q8 9220 2076 2094 2076
q9 8998 6528 6525 6525
q10 9007 3760 3715 3715
q11 455 236 233 233
q12 490 241 232 232
q13 17762 3022 2996 2996
q14 276 215 216 215
q15 515 472 479 472
q16 541 377 375 375
q17 964 670 666 666
q18 8234 8126 7936 7936
q19 4982 1400 1324 1324
q20 715 337 330 330
q21 5148 3445 4056 3445
q22 408 344 341 341
Total cold run time: 116686 ms
Total hot run time: 40604 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4602 4391 4513 4391
q2 371 268 253 253
q3 3091 2902 2911 2902
q4 1982 1657 1741 1657
q5 5512 5580 5493 5493
q6 231 130 133 130
q7 2212 1814 1892 1814
q8 3222 3524 3411 3411
q9 8694 8702 8724 8702
q10 4036 3877 3907 3877
q11 601 504 515 504
q12 874 649 655 649
q13 16967 3005 3140 3005
q14 297 257 282 257
q15 525 475 483 475
q16 473 418 437 418
q17 1825 1493 1490 1490
q18 8194 7959 7725 7725
q19 1769 1599 1686 1599
q20 2823 1863 1849 1849
q21 5144 4887 5048 4887
q22 655 552 548 548
Total cold run time: 74100 ms
Total hot run time: 56036 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](spill) Delete not used code [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36218:
URL: https://github.com/apache/doris/pull/36218#issuecomment-2164935084
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](spill) Delete not used code [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36218:
URL: https://github.com/apache/doris/pull/36218#issuecomment-2164935154
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](spill) Delete not used code [doris]
Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #36218:
URL: https://github.com/apache/doris/pull/36218#issuecomment-2164526150
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](spill) Delete not used code [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36218:
URL: https://github.com/apache/doris/pull/36218#issuecomment-2164257506
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](spill) Delete not used code [doris]
Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg merged PR #36218:
URL: https://github.com/apache/doris/pull/36218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](spill) Delete not used code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36218:
URL: https://github.com/apache/doris/pull/36218#issuecomment-2164330792
<details>
<summary>TPC-DS: <b>Total hot run time: 173595 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 418d878b75e3157c368d26e0b471e1d486150f42, data reload: false
query1 810 381 367 367
query2 6378 2519 2347 2347
query3 6388 206 205 205
query4 18924 17324 17152 17152
query5 3793 487 458 458
query6 259 158 155 155
query7 4467 300 291 291
query8 338 281 280 280
query9 8353 2473 2442 2442
query10 572 335 278 278
query11 10652 10109 10121 10109
query12 134 98 83 83
query13 1570 369 359 359
query14 10181 6861 7676 6861
query15 233 179 187 179
query16 7563 266 269 266
query17 1383 545 514 514
query18 1947 292 274 274
query19 196 154 149 149
query20 91 85 104 85
query21 210 131 127 127
query22 4316 4162 3953 3953
query23 33854 33618 33705 33618
query24 11121 2841 2878 2841
query25 591 355 358 355
query26 1045 154 157 154
query27 2303 319 327 319
query28 6769 2099 2064 2064
query29 874 616 607 607
query30 255 153 157 153
query31 956 761 748 748
query32 94 55 57 55
query33 804 281 275 275
query34 928 466 490 466
query35 742 636 632 632
query36 1085 928 950 928
query37 140 66 68 66
query38 2902 2760 2726 2726
query39 841 809 798 798
query40 203 128 127 127
query41 54 51 52 51
query42 120 97 96 96
query43 582 536 574 536
query44 1200 747 730 730
query45 193 169 165 165
query46 1071 723 716 716
query47 1854 1746 1810 1746
query48 389 323 304 304
query49 876 420 406 406
query50 756 403 394 394
query51 6758 6629 6639 6629
query52 105 90 95 90
query53 348 289 286 286
query54 870 449 449 449
query55 73 75 74 74
query56 275 263 265 263
query57 1179 1013 1027 1013
query58 238 244 241 241
query59 3394 3216 3251 3216
query60 299 282 304 282
query61 121 110 111 110
query62 616 441 441 441
query63 327 292 287 287
query64 8791 2236 1729 1729
query65 3183 3113 3076 3076
query66 935 322 325 322
query67 15424 14988 15114 14988
query68 4530 535 554 535
query69 627 434 363 363
query70 1112 1150 1100 1100
query71 385 280 280 280
query72 8371 5701 5584 5584
query73 762 326 330 326
query74 5854 5479 5555 5479
query75 3551 2660 2646 2646
query76 2819 980 931 931
query77 587 309 295 295
query78 10227 9859 9862 9859
query79 2275 514 511 511
query80 1356 469 460 460
query81 546 222 220 220
query82 753 108 97 97
query83 190 171 167 167
query84 268 91 85 85
query85 1280 280 290 280
query86 454 333 331 331
query87 3274 3056 3070 3056
query88 3792 2483 2464 2464
query89 531 397 376 376
query90 1848 188 193 188
query91 126 95 99 95
query92 61 54 51 51
query93 2149 502 503 502
query94 1200 191 190 190
query95 416 317 323 317
query96 598 269 268 268
query97 3208 3006 3050 3006
query98 214 208 192 192
query99 1246 835 853 835
Total cold run time: 268906 ms
Total hot run time: 173595 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](spill) Delete not used code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36218:
URL: https://github.com/apache/doris/pull/36218#issuecomment-2164251814
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](spill) Delete not used code [doris]
Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #36218:
URL: https://github.com/apache/doris/pull/36218#issuecomment-2164252559
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](spill) Delete not used code [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36218:
URL: https://github.com/apache/doris/pull/36218#issuecomment-2164336217
<details>
<summary>ClickBench: <b>Total hot run time: 30.41 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 418d878b75e3157c368d26e0b471e1d486150f42, data reload: false
query1 0.04 0.03 0.04
query2 0.07 0.03 0.04
query3 0.22 0.05 0.06
query4 1.68 0.06 0.07
query5 0.51 0.46 0.48
query6 1.13 0.73 0.72
query7 0.01 0.01 0.02
query8 0.05 0.04 0.05
query9 0.55 0.49 0.48
query10 0.55 0.56 0.52
query11 0.16 0.12 0.12
query12 0.14 0.12 0.12
query13 0.60 0.58 0.61
query14 0.77 0.79 0.78
query15 0.83 0.81 0.82
query16 0.37 0.36 0.36
query17 1.00 0.95 1.04
query18 0.20 0.25 0.24
query19 1.81 1.67 1.72
query20 0.02 0.01 0.01
query21 15.41 0.67 0.66
query22 4.43 7.13 1.88
query23 18.26 1.34 1.28
query24 2.08 0.22 0.21
query25 0.16 0.08 0.09
query26 0.27 0.17 0.16
query27 0.08 0.08 0.10
query28 13.27 1.01 1.01
query29 12.59 3.25 3.23
query30 0.26 0.06 0.06
query31 2.88 0.38 0.38
query32 3.27 0.47 0.48
query33 2.90 2.86 2.98
query34 17.18 4.45 4.53
query35 4.50 4.48 4.50
query36 0.65 0.47 0.47
query37 0.18 0.16 0.16
query38 0.15 0.15 0.15
query39 0.04 0.04 0.03
query40 0.18 0.14 0.15
query41 0.10 0.05 0.05
query42 0.06 0.04 0.05
query43 0.04 0.04 0.04
Total cold run time: 109.65 s
Total hot run time: 30.41 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org